Linux: add lag support and bonding plugin for non-lag cases #1624

jbemmel · 2024-12-08T22:50:06Z

Refactor and reuse FRR logic for bond creation on Linux, both for the lag module and for the bonding plugin
Support all the Linux bonding modes, split into:
- lag module: [ 802.3ad, balance-rr, balance-xor, broadcast ] - these require switch support
- bonding plugin: [ active-backup, balance-tlb, balance-alb ]

In all cases, bonding devices are created in initial such that any IP addresses can be assigned. Bond/lag members are then added in the respective lag module and bonding plugin

Executes in netns for containers -> no need to install iproute2

Tested:

netlab up integration/lag/05-bonding-active-standby.yml -p clab
netlab up integration/lag/05-bonding-active-standby.yml -p libvirt
netlab up integration/lag/06-host-mlag-anycast-gateway.yml -p clab -d dellos10

ipspace

A few minor details plus a major problem: we don't get the Linux static routes for the lab pools (they are supposed to point to the first data-plane interface), so the Linux host cannot reach anything but the adjacent router.

Fix the nits and I'll add the static routes part.

netsim/devices/linux.yml

netsim/ansible/templates/lag/linux.j2

ipspace · 2024-12-09T09:28:12Z

Also, just wondering: how does netplan-based Ubuntu configuration work with handcrafted bond devices?

jbemmel · 2024-12-09T14:26:54Z

Also, just wondering: how does netplan-based Ubuntu configuration work with handcrafted bond devices?

It shows them as "unmanaged" just like the 'lo' device (odd to see that), but I agree it would be nicer to craft netplan configs where available. Will adjust

ipspace · 2024-12-11T13:00:29Z

Fix the nits and I'll add the static routes part.

Static route issue is tracked in #1641. I will probably go for a simple fix in the configuration template (that code is ancient)

jbemmel · 2024-12-16T03:44:57Z

Ready to add the static route bits

ipspace

A bunch of confused comments and a few minor changes. Also, it looks like it's time for a rebase.

docs/caveats.md

docs/plugins/bonding.md

netsim/augment/links.py

netsim/extra/bonding/plugin.py

ipspace · 2024-12-23T06:15:22Z

netsim/modules/lag.yml

@@ -12,19 +12,21 @@ attributes:
  global:
    lacp: { type: str, valid_values: [ "off", "slow", "fast" ] }
    lacp_mode: { type: str, valid_values: [ "passive", "active" ] }
-    mode: { type: str, valid_values: [ "802.3ad", "balance-xor", "active-backup" ] }
+
+    # All Linux bonding modes that require lag configuration on the switch side


The only bonding mode that requires switch configuration is "802.3ad" or am I missing something? Why exactly do you think we need Linux bonding modes in the generic LAG module?

Based on https://docs.redhat.com/en/documentation/red_hat_enterprise_linux/7/html/networking_guide/overview-of-bonding-modes-and-the-required-settings-on-the-switch#overview-of-bonding-modes-and-the-required-settings-on-the-switch

Table 7.1. Switch Configuration Settings Depending on the Bonding Modes Bonding Mode Configuration on the Switch 0 - balance-rr Requires static Etherchannel enabled (not LACP-negotiated) 1 - active-backup Requires autonomous ports 2 - balance-xor Requires static Etherchannel enabled (not LACP-negotiated) 3 - broadcast Requires static Etherchannel enabled (not LACP-negotiated) 4 - 802.3ad Requires LACP-negotiated Etherchannel enabled 5 - balance-tlb Requires autonomous ports 6 - balance-alb Requires autonomous ports

So 0, 2, 3 and 4 require lag configuration on the switch side, with only 4 including LACP.

1, 5 and 6 are handled by the bonding plugin (server-side config only)

jbemmel · 2024-12-23T18:01:53Z

One issue: We need to execute the ip command on the host, from within the container namespace context. This happens for initial during bond device creation, but the bond members are added during lag module execution which (currently) happens inside the container (hence depends on ip etc.)

I'm thinking we need a mechanism to control the execution context of provisioning scripts in case of Linux containers: Either on the host (for initial and lag modules), or "normal" as is done for dhcp. Perhaps a convention in the filename: e.g. linux-host.j2 for network namespace execution, and regular linux.j2 for current practice

Thoughts?

… image)

…the device bond1 instead of eth1 IP allocation doesn't work the same - possibly some dependency on link.type

( this is an example why Ivan doesn't like link.type=='lag'... )

…comes stub). Some cleanup remains required

Moved to a new 'bonding' plugin as it is not link aggregation

* iproute2 shouldn't be needed with netplan * Note: bonding plugin cannot run in netns context

ipspace · 2024-12-31T08:36:24Z

Looks like you're still working on this one. When you're done, please mark it as "ready for review"

jbemmel · 2024-12-31T13:05:59Z

Looks like you're still working on this one. When you're done, please mark it as "ready for review"

It's ready, all I did was rebase it. I'm waiting on this one before merging #1646

jbemmel mentioned this pull request Dec 8, 2024

lag: Support M:M MLAG topologies #1604

Merged

ipspace requested changes Dec 9, 2024

View reviewed changes

netsim/devices/linux.yml Outdated Show resolved Hide resolved

netsim/ansible/templates/lag/linux.j2 Outdated Show resolved Hide resolved

jbemmel marked this pull request as draft December 9, 2024 14:25

jbemmel force-pushed the linux_add_lag_support branch from 33e1ee4 to d20c7ef Compare December 10, 2024 17:36

jbemmel force-pushed the linux_add_lag_support branch from a884b6f to 1cb4cea Compare December 15, 2024 19:26

jbemmel changed the title ~~Linux: add lag support~~ Linux: add lag support and bonding plugin for non-lag cases Dec 15, 2024

jbemmel marked this pull request as ready for review December 16, 2024 03:44

ipspace requested changes Dec 23, 2024

View reviewed changes

ipspace marked this pull request as draft December 23, 2024 06:16

jbemmel force-pushed the linux_add_lag_support branch from e4439bf to def1a35 Compare December 23, 2024 17:18

jbemmel force-pushed the linux_add_lag_support branch from e7bb543 to 130ad54 Compare December 25, 2024 13:54

jbemmel marked this pull request as ready for review December 25, 2024 17:23

jbemmel added 13 commits December 30, 2024 06:36

Linux: add lag support (borrowed from frr)

5a6d11b

Refactored, move lag bond creation to linux.j2

483adf0

Move to MLAG PR

cb3ad9f

Undo changes to image version

4a61608

Move FRR bond logic to generic Linux template

46f632a

Update docs

7e09c25

Adjust title

0bd66c0

Add iproute2 for good measure (in case we ever change the Ubuntu base…

3e47c52

… image)

Use single brackets that work with 'sh' shell too

7fb58f3

Update test case - with a bond should be the same as without, modulo …

eea3d41

…the device bond1 instead of eth1 IP allocation doesn't work the same - possibly some dependency on link.type

Treat lag links with a VLAN as LAN, not p2p

ed06e3c

( this is an example why Ivan doesn't like link.type=='lag'... )

In case of active-standby mlag, do create the interface (else link be…

4dfdff3

…comes stub). Some cleanup remains required

lag: Remove active-backup as a valid value

6ab6fa5

Moved to a new 'bonding' plugin as it is not link aggregation

jbemmel added 24 commits December 30, 2024 06:36

Set device down before changing bond master

5b4cdb7

Rename test case

a0918b4

Merge with dev branch changes

5b20520

Update caveat docs

9572146

Run lag script from within ip netns context in case of clab provider

b8bade9

Fix block syntax, revert to old style lag matching

fa3b59a

Restructure

68fc4bc

Fix Ubuntu netplan config

42a7944

Remove reference to non-existing section

5632707

Updated in response to comments

07d1ffd

'interfaces' should be 'neighbors' - clarify

0fa252f

Fix English

05473f4

* Add 'primary' config on Ubuntu

c122053

* iproute2 shouldn't be needed with netplan * Note: bonding plugin cannot run in netns context

Fix typing

c2b0af1

Take advantage of netns execution where available

0928c4a

Remove endif and indent

5783a24

Only install ip

3624fa1

Add caveat

8958005

Make sure to remove any MTU setting from lag interfaces

0559587

Make sure #!/bin/bash line appears at top

c89d6d4

Remove MTU from lag interfaces

9ef8a77

Postpone MTU removal to next PR

a03b3eb

Fix indentation, check if IP addresses are strings

484d3bd

Add caveat about multi-provider labs, addressed in separate PR

4c5f63a

jbemmel force-pushed the linux_add_lag_support branch from 8c43217 to 4c5f63a Compare December 30, 2024 12:37

ipspace marked this pull request as draft December 31, 2024 08:35

jbemmel marked this pull request as ready for review December 31, 2024 13:04

ipspace merged commit 00a988b into ipspace:dev Jan 1, 2025
6 checks passed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Linux: add lag support and bonding plugin for non-lag cases #1624

Linux: add lag support and bonding plugin for non-lag cases #1624

jbemmel commented Dec 8, 2024 •

edited

Loading

ipspace left a comment

ipspace commented Dec 9, 2024

jbemmel commented Dec 9, 2024

ipspace commented Dec 11, 2024

jbemmel commented Dec 16, 2024

ipspace left a comment

ipspace Dec 23, 2024

jbemmel Dec 23, 2024

jbemmel commented Dec 23, 2024

ipspace commented Dec 31, 2024

jbemmel commented Dec 31, 2024

Linux: add lag support and bonding plugin for non-lag cases #1624

Linux: add lag support and bonding plugin for non-lag cases #1624

Conversation

jbemmel commented Dec 8, 2024 • edited Loading

ipspace left a comment

Choose a reason for hiding this comment

ipspace commented Dec 9, 2024

jbemmel commented Dec 9, 2024

ipspace commented Dec 11, 2024

jbemmel commented Dec 16, 2024

ipspace left a comment

Choose a reason for hiding this comment

ipspace Dec 23, 2024

Choose a reason for hiding this comment

jbemmel Dec 23, 2024

Choose a reason for hiding this comment

jbemmel commented Dec 23, 2024

ipspace commented Dec 31, 2024

jbemmel commented Dec 31, 2024

jbemmel commented Dec 8, 2024 •

edited

Loading