Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add dequeue enqueue stats #98

Open
wants to merge 3 commits into
base: main
Choose a base branch
from
Open

Add dequeue enqueue stats #98

Changes from 1 commit
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
f38fbb6
add: multiple operation duration stats
CorentinB Jul 26, 2024
4bd802d
fix: deadlock
CorentinB Jul 26, 2024
e1a1493
remove: useless stats
CorentinB Jul 26, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 0 additions & 3 deletions internal/pkg/queue/stats.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -174,9 +174,6 @@ func (q *PersistentGroupedQueue) calculateAverageDuration(samples []Sample) OpAv
}

func (q *PersistentGroupedQueue) addSample(duration time.Duration, sampleType SampleType) {
q.stats.Lock()
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

you sure this will not cause any data race?

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

you sure this will not cause any data race?

I'm not sure any lock is needed at the stats level here considering the entire queue struct (which hold the stats) is locked in Enqueue and Dequeue ?

defer q.stats.Lock()

newSample := Sample{
timestamp: time.Now(),
duration: duration,
Expand Down