Add dequeue enqueue stats #98
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
equals215
reviewed
Jul 26, 2024
internal/pkg/queue/stats.go
Outdated
| @@ -174,9 +174,6 @@ func (q *PersistentGroupedQueue) calculateAverageDuration(samples []Sample) OpAv | |||
| } | |||
|
|
|||
| func (q *PersistentGroupedQueue) addSample(duration time.Duration, sampleType SampleType) { | |||
| q.stats.Lock() | |||
There was a problem hiding this comment.
you sure this will not cause any data race?
There was a problem hiding this comment.
you sure this will not cause any data race?
I'm not sure any lock is needed at the stats level here considering the entire queue struct (which hold the stats) is locked in Enqueue and Dequeue ?
|
also can we display the stats using |
Nah, I don't think we should add too much stuff to live-stats.. We already added a lot with the recent PRs. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.