Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix for Amazon failing. #1599

Merged
merged 1 commit into from
Oct 11, 2024
Merged

Fix for Amazon failing. #1599

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 8 additions & 1 deletion build.gradle
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -137,9 +137,16 @@ dependencies {
[group: 'software.amazon.awssdk', name: 'cognitoidentity', version: amazonVersion],
[group: 'software.amazon.awssdk', name: 'sts', version: amazonVersion],
[group: 'software.amazon.awssdk', name: 's3', version: amazonVersion],
[group: 'software.amazon.awssdk', name: 'sso', version: amazonVersion]
[group: 'software.amazon.awssdk', name: 'sso', version: amazonVersion],

// This is a transitive dependency from amazon but due to modularization changes between
// 1.20 and 1.3.0 we need to specify it here.
// This can be removed when amazon moves from 1.2.0 -> 1.3.0 and updates it's module requirements
// See https://logging.apache.org/blog/2023/12/02/apache-common-logging-1.3.0.html
[group: 'commons-logging', name: 'commons-logging', version: '1.3.0']
)


testImplementation(
[group: 'junit', name: 'junit', version: '4.13.2'],
[group: 'com.sparkjava', name: 'spark-core', version: '2.9.4'],
Expand Down
4 changes: 4 additions & 0 deletions src/main/java/module-info.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -43,5 +43,9 @@
requires software.amazon.awssdk.http;
requires software.amazon.awssdk.utils;

// Transitive dependency of amazon modules that is required to be specified
// because amazon resolves the unmodularized 1.2.0 version while htjsdk brings in the modular 1.3.0
requires org.apache.commons.logging;

requires jide.oss;
}
Loading