Fix for Amazon failing. #1599
Fix for Amazon failing. #1599
Conversation
* Fix the amazon failures due to LogFactory not found by adding a module dependency * on apache logging. This is necessary because commons-logging became modularized * between 1.2.0 and 1.3.0 but amazon is expecting the non-modular 1.2.0 while * 1.3.0 is being brought in due to changes in htsjdk. * See https://logging.apache.org/blog/2023/12/02/apache-common-logging-1.3.0.html for * more info. * Fix for #1598
|
@jrobinso Please can you expedite this fix and cut a new IGV release ASAP? Our team is currently experiencing some issues that seem to point to this. /cc @ohofmann @victorskl |
|
We're targetting a release for the end of the month. In the meantime I suggest you use 2.18.1. Alternatively you could use the "snapshot" build, in fact it would be useful to know if that build resolves your issues. If it doesn't then cutting a new release will not either. You can install it from https://igv.org/doc/desktop/#DownloadSnapshot/ |
|
Thanks Jim, we had to ship a fix at our data portal frontend (outside of IGV) as a workaround so we're good for now, we'll potentially revert that change and test out the new release or test with our dev environment. |
|
Jim, tested on our dev environment and indeed the snapshot build 2024-11-22 seems to fix the issue. I'll circulate the snapshot release now to our curators for now, but I'd prefer to have a point release for easier tracking of changes and compliance. |
|
I am building release 2.19.0, which includes this fix now. However we are
running into holidays here and it might not be released on the website
until Monday. I can provide links for download when its notarized (for
Macs), which will be sometime tomorrow.
…On Tue, Nov 26, 2024 at 8:17 PM Roman Valls Guimera < ***@***.***> wrote:
Jim, tested on our dev environment and indeed the snapshot build
2024-11-22 seems to fix the issue.
I'll circulate the snapshot release now to our curators for now, but I'd
prefer to have a point release for easier tracking of changes and
compliance.
—
Reply to this email directly, view it on GitHub
<#1599 (comment)>, or
unsubscribe
<https://github.com/notifications/unsubscribe-auth/AAHD2HBQEZPXBTX6SLGKN3D2CVBWXAVCNFSM6AAAAABPZB4PECVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDKMBSGY4TENZYHA>
.
You are receiving this because you were mentioned.Message ID:
***@***.***>
|
|
Thanks Jim, very much appreciated!!! |
|
We're having trouble with Mac notarization, that won't get resolved before the holidays. Links below for Windows and the generic command line build |
@jrobinso Can you test this on your system before we merge? It seems to fix the problem for me but I want to be sure it's also fixing it for you.