Replace GregorianCalendar with java.time.OffsetDateTime in CurrentTimeUTC #866
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…eUTC Now CurrentTimeUTC uses newer java.time API. This change also removes unnecessary synchronization on the GregorianCalendar object.
s/currentTimeMilis/currentTimeMillis/g add javadoc link to System#currentTimeMillis()
Bombe
reviewed
Oct 8, 2023
bertm
reviewed
Oct 12, 2023
java.util.Date default constructor creates a date value, which has UTC zone offset by default. This time value comes from System.currentTimeMillis().
LocalDate has additional methods to access parts of the date. Public methods in the CurrentTimeUTC provide values related to dates only, therefore using LocalDate there is more natural than OffsetDateTime.
|
I made changes mentioned in review. I may also create a deprecation PR and remove usages of this class. |
At work we have the policy that every deprecation needs a comment people can copy paste to replace the usage of the deprecated method. I would suggest doing that here, too. We cannot remove this until there isn’t a single use in plugins. |
ArneBab
approved these changes
Oct 14, 2023
|
merged - thank you! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Now
CurrentTimeUTCuses newerjava.timeAPI.This change also removes unnecessary synchronization on the
GregorianCalendarobject.