Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Deprecate CurrentTimeUTC #870

Merged
merged 2 commits into from
Nov 26, 2023
Merged

Conversation

bertm
Copy link
Contributor

@bertm bertm commented Oct 14, 2023

Follow-up on discussion in #866

@ArneBab
Copy link
Contributor

ArneBab commented Oct 14, 2023

Thank you for stepping up. Currently the comments do not enable quick replacement.

Please try to put yourself in the shoes of someone who wrote a plugin three years ago and since then has only programmed websites with vue or similar. The comment needs to enable them to adjust the code without investigating, otherwise it will never be possible to turn this into deprecation for removal. There are already modified plugins in use. If it’s not trivial (in the strictest sense) to replace the deprecation, removing the deprecated version will still break plugins in the next decade.

@bertm bertm force-pushed the deprecate-current-time-utc branch from 1218e76 to c91ec6f Compare October 14, 2023 21:19
@bertm
Copy link
Contributor Author

bertm commented Oct 14, 2023

I would not expect plugin developers to need this level of hand-holding in finding alternatives for these (until now mostly undocumented) methods. I've now updated the deprecation notices with verbatim copies of the new implementations provided in #866 to allow for a copy-paste migration path.

@bertm bertm force-pushed the deprecate-current-time-utc branch from c91ec6f to 09f1fce Compare October 14, 2023 23:05
bertm added 2 commits October 15, 2023 17:26
The Java 8 Date-Time APIs provide superior alternatives for the methods
provided in this class.
Only get() and getInMillis() were used within Fred. These methods can
trivially be replaced by new Date() and System.currentTimeMillis()
respectively.
@bertm bertm force-pushed the deprecate-current-time-utc branch from 09f1fce to b53b937 Compare October 15, 2023 15:27
@bertm
Copy link
Contributor Author

bertm commented Oct 15, 2023

Updated the commits to have GPG signatures.

Copy link
Contributor

@Bombe Bombe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🔥🔥🔥

@ArneBab ArneBab merged commit 1372189 into hyphanet:next Nov 26, 2023
1 check passed
@ArneBab
Copy link
Contributor

ArneBab commented Nov 26, 2023

@bertm merged — thank you! And welcome back! It’s great to see you again ❤️

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants