Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Power Control rewritten to Libgpiod #115

Merged
merged 21 commits into from
Jul 5, 2023
Merged

Conversation

Kotochleb
Copy link
Contributor

@Kotochleb Kotochleb commented May 10, 2023

bump::patch

Remove RPi.GPIO and use Libgpiod for GPIO control.
Currently, the implementation assumes hard-coded pin numbers for older robots.

@Kotochleb Kotochleb requested a review from KmakD May 10, 2023 13:47
@Kotochleb Kotochleb marked this pull request as ready for review May 10, 2023 14:00
panther_power_control/src/power_board_node.py Outdated Show resolved Hide resolved
panther_power_control/src/power_board_node.py Outdated Show resolved Hide resolved
panther_power_control/src/power_board_node.py Outdated Show resolved Hide resolved
panther_power_control/src/power_board_node.py Outdated Show resolved Hide resolved
panther_power_control/src/power_board_node.py Outdated Show resolved Hide resolved
panther_power_control/src/power_board_node.py Outdated Show resolved Hide resolved
panther_power_control/src/power_board_node.py Outdated Show resolved Hide resolved
panther_power_control/src/power_board_node.py Outdated Show resolved Hide resolved
panther_power_control/src/relays_node.py Outdated Show resolved Hide resolved
panther_power_control/src/power_board_node.py Outdated Show resolved Hide resolved
panther_power_control/src/power_board_node.py Outdated Show resolved Hide resolved
panther_power_control/src/power_board_node.py Outdated Show resolved Hide resolved
panther_power_control/src/power_board_node.py Outdated Show resolved Hide resolved
@KmakD KmakD added invalid This doesn't seem right wontfix This will not be worked on and removed invalid This doesn't seem right wontfix This will not be worked on labels Jun 23, 2023
@Kotochleb Kotochleb requested a review from KmakD June 26, 2023 11:57
panther_power_control/src/relays_node.py Outdated Show resolved Hide resolved
@Kotochleb Kotochleb requested a review from KmakD June 27, 2023 09:37
@Kotochleb Kotochleb added invalid This doesn't seem right wontfix This will not be worked on and removed invalid This doesn't seem right labels Jun 27, 2023
@Kotochleb Kotochleb removed the wontfix This will not be worked on label Jun 27, 2023
Copy link
Contributor

@macstepien macstepien left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think that python code wasn't formatted with black

panther_power_control/src/power_board_node.py Outdated Show resolved Hide resolved
panther_power_control/src/power_board_node.py Show resolved Hide resolved
panther_power_control/src/relays_node.py Outdated Show resolved Hide resolved
@macstepien
Copy link
Contributor

I think that python code wasn't formatted with black

bump

@Kotochleb Kotochleb requested a review from macstepien July 3, 2023 16:28
@macstepien macstepien merged commit d53e5aa into ros1 Jul 5, 2023
@macstepien macstepien deleted the ros1-libgpiod-power-control branch July 5, 2023 10:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants