Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: add tagging for docker images #40

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

chore: add tagging for docker images #40

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
3bb1012
chore: add tagging for docker images
Paul-weqe Dec 27, 2024
945e7bf
chore: deal with clippy issues
Paul-weqe Dec 27, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 4 additions & 1 deletion .github/workflows/ci.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -73,5 +73,8 @@ jobs:
password: ${{secrets.GITHUB_TOKEN}}
- name: Build and push container image
run: |
docker build . -f docker/Dockerfile --tag ghcr.io/holo-routing/holo:latest
docker build . -f docker/Dockerfile --tag ghcr.io/holo-routing/holo:latest ghcr.io/holo-routing/holo:0.6.0
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This would cause all CI runs on master to update the v0.6.0 image as well.

It might be easier to push release versions manually. If we want to automate this via CI, we'll need to check if the git commit has an associated tag. Then, if it does, the CI should push a docker image tagged with that version. If not, the CI should default to using the holo:latest tag.


docker push ghcr.io/holo-routing/holo:latest
docker push ghcr.io/holo-routing/holo:0.6.0

4 changes: 2 additions & 2 deletions holo-bfd/src/packet.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -103,8 +103,8 @@ impl Packet {
let mut buf = buf.borrow_mut();
buf.clear();

buf.put_u8(self.version << 5 | self.diag);
buf.put_u8((self.state as u8) << 6 | self.flags.bits());
buf.put_u8((self.version << 5) | self.diag);
buf.put_u8(((self.state as u8) << 6) | self.flags.bits());
buf.put_u8(self.detect_mult);
// The length will be initialized later.
buf.put_u8(0);
Expand Down
4 changes: 2 additions & 2 deletions holo-ospf/src/ospfv3/packet/mod.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -915,12 +915,12 @@ fn packet_options(data: &[u8]) -> Option<Options> {
match pkt_type {
PacketType::Hello => {
let options = &data[PacketHdr::LENGTH as usize + 6..];
let options = (options[0] as u16) << 8 | options[1] as u16;
let options = ((options[0] as u16) << 8) | options[1] as u16;
Some(Options::from_bits_truncate(options))
}
PacketType::DbDesc => {
let options = &data[PacketHdr::LENGTH as usize + 2..];
let options = (options[0] as u16) << 8 | options[1] as u16;
let options = ((options[0] as u16) << 8) | options[1] as u16;
Some(Options::from_bits_truncate(options))
}
PacketType::LsRequest | PacketType::LsUpdate | PacketType::LsAck => {
Expand Down
2 changes: 1 addition & 1 deletion holo-vrrp/src/packet.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -217,7 +217,7 @@ impl Ipv4Hdr {
let mut buf = BytesMut::new();

// ver_ihl -> version[4 bits] + ihl[4 bits]
buf.put_u8(self.version << 4 | self.ihl);
buf.put_u8((self.version << 4) | self.ihl);
buf.put_u8(self.tos);
buf.put_u16(self.total_length);
buf.put_u16(self.identification);
Expand Down
Loading