chore: add tagging for docker images #40
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Paul Wekesa <[email protected]>
latest nightly update has new clippy rules. Implemented here. Signed-off-by: Paul Wekesa <[email protected]>
rwestphal
reviewed
Jan 2, 2025
| @@ -73,5 +73,8 @@ jobs: | |||
| password: ${{secrets.GITHUB_TOKEN}} | |||
| - name: Build and push container image | |||
| run: | | |||
| docker build . -f docker/Dockerfile --tag ghcr.io/holo-routing/holo:latest | |||
| docker build . -f docker/Dockerfile --tag ghcr.io/holo-routing/holo:latest ghcr.io/holo-routing/holo:0.6.0 | |||
There was a problem hiding this comment.
This would cause all CI runs on master to update the v0.6.0 image as well.
It might be easier to push release versions manually. If we want to automate this via CI, we'll need to check if the git commit has an associated tag. Then, if it does, the CI should push a docker image tagged with that version. If not, the CI should default to using the holo:latest tag.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Docker images currently only have :latest tag