Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: keepalived weights and slave naming #977

Merged
merged 3 commits into from
Nov 7, 2024

Conversation

gseidel
Copy link
Contributor

@gseidel gseidel commented Oct 18, 2024

According to https://manpages.debian.org/testing/keepalived/keepalived.conf.5.en.html

(b) vrrp tracking scripts that will cause vrrp instances to go down it they exit a 
non-zero exist status, or if a weight is specified will add or subtract
the weight to/from the priority of that vrrp instance.

Means if the master priortiy is 200 and vrrp weight is 101 ...
and vrrp succeed, the master priortiy is 301
and vrrp fails, the master priortiy is 200

The backup is always 100, so it will never failover!

Guess the weight should be -101 so the priority get 99 and is below 100.

On the other hand, the docs and also the logs always talking about the backup daemon and never about slave, so I changed the namings as well.

@svenja11 svenja11 added review wanted Request a review Existing tutorial Changes on an existing tutorial labels Oct 18, 2024
@svenja11
Copy link
Collaborator

svenja11 commented Nov 7, 2024

Thank you for the update @gseidel!

Please add this comment to this PR, and I will merge it (remember to replace YOUR NAME <[email protected]> with your own information):

I have read and understood the Contributor's Certificate of Origin available at the end of
https://raw.githubusercontent.com/hetzneronline/community-content/master/tutorial-template.md
and I hereby certify that I meet the contribution criteria described in it.
Signed-off-by: YOUR NAME [email protected]

@svenja11 svenja11 added ready and removed review wanted Request a review labels Nov 7, 2024
@gseidel
Copy link
Contributor Author

gseidel commented Nov 7, 2024

@svenja11 You are welcome.

I have read and understood the Contributor's Certificate of Origin available at the end of
https://raw.githubusercontent.com/hetzneronline/community-content/master/tutorial-template.md
and I hereby certify that I meet the contribution criteria described in it.
Signed-off-by: Gerhard Seidel [email protected]

@svenja11 svenja11 merged commit ab32ec6 into hetzneronline:master Nov 7, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Existing tutorial Changes on an existing tutorial ready
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants