Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add missing paths exclusion to the documentation #55

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

Polaris-Dust
Copy link

docs: Add excludes to archive data argument list

@mattelacchiato
Copy link

Why does this not get merged?

@chuckwondo
Copy link

I'm glad to see excludes is supported.

However, the addition to the docs doesn't provide any details on what type of value is supported. Is the excludes value a list? Is it a string? In either case, what are acceptable values? Are they only exact paths? Are they patterns?

For example, would the following be a possible value?

excludes = ["test", "src/**/*.ts"]

@manasouza
Copy link

Hi @chuckwondo

For example, would the following be a possible value?

excludes = ["test", "src/**/*.ts"]

I tried to accomplish something to cover that on PR #57 but seems that the repo maintainers are not available for a while

damacus added a commit to damacus/terraform-aws-lambda-auto-package that referenced this pull request Apr 30, 2020
The undocumented excludes option to acrhive file is extremely helpful
when you have test code included in the same directory as the lambda

hashicorp/terraform-provider-archive#55
damacus added a commit to damacus/terraform-aws-lambda-auto-package that referenced this pull request May 10, 2020
* Adds exclude_files option to archive

The undocumented excludes option to acrhive file is extremely helpful
when you have test code included in the same directory as the lambda

hashicorp/terraform-provider-archive#55

* Fix default values for archive ignore
nozaq added a commit to nozaq/terraform-aws-lambda-auto-package that referenced this pull request May 17, 2020
* Adds exclude_files option to archive

The undocumented excludes option to acrhive file is extremely helpful
when you have test code included in the same directory as the lambda

hashicorp/terraform-provider-archive#55

* Fix default values for archive ignore

Co-authored-by: nozaq <[email protected]>
nozaq added a commit to nozaq/terraform-aws-lambda-auto-package that referenced this pull request May 17, 2020
* Add/archive ignore (#1)

* Adds exclude_files option to archive

The undocumented excludes option to acrhive file is extremely helpful
when you have test code included in the same directory as the lambda

hashicorp/terraform-provider-archive#55

* Fix default values for archive ignore

* Adds the ability to trigger the lambda from additional sources such as
API Gateway

Co-authored-by: nozaq <[email protected]>
@hashicorp-cla
Copy link

CLA assistant check

Thank you for your submission! We require that all contributors sign our Contributor License Agreement ("CLA") before we can accept the contribution. Read and sign the agreement

Learn more about why HashiCorp requires a CLA and what the CLA includes

Have you signed the CLA already but the status is still pending? Recheck it.

Base automatically changed from master to main February 1, 2021 17:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants