Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adds exclude_files option to archive #8

Merged
merged 3 commits into from
May 17, 2020

Conversation

damacus
Copy link
Contributor

@damacus damacus commented Apr 30, 2020

The undocumented excludes option to acrhive file is extremely helpful
when you have test code included in the same directory as the lambda

hashicorp/terraform-provider-archive#55

The undocumented excludes option to acrhive file is extremely helpful
when you have test code included in the same directory as the lambda

hashicorp/terraform-provider-archive#55
@damacus
Copy link
Contributor Author

damacus commented Apr 30, 2020

I'll fix that example tomorrow.

@damacus
Copy link
Contributor Author

damacus commented May 10, 2020

@nozaq this should be ready to review now :)

@nozaq nozaq added the enhancement New feature or request label May 17, 2020
@nozaq nozaq self-assigned this May 17, 2020
@nozaq
Copy link
Owner

nozaq commented May 17, 2020

@damacus Thanks for the proposal, looks great to me! 👍

@nozaq nozaq merged commit 98dff8c into nozaq:master May 17, 2020
@damacus damacus deleted the add/archive-ignore branch May 17, 2020 17:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants