Add archive_dir property to be used with source_dir that will prefix … #125
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
|
Now that I've issued this, I see this is similar to #113. If that can address the other issues, then this PR is not needed. |
|
@teamterraform, not sure what the intake process is here. Is a PR reviewer typically assigned automatically? I do see a related PR but it seems to be very stale. |
|
@teamterraform, anything we can do to move this forward? |
KevinEady
reviewed
Apr 20, 2023
| @@ -78,6 +78,8 @@ NOTE: One of `source`, `source_content_filename` (with `source_content`), `sourc | |||
|
|
|||
| * `source_dir` - (Optional) Package entire contents of this directory into the archive. | |||
|
|
|||
There was a problem hiding this comment.
Meant to link to
terraform-provider-archive/website/docs/d/archive_file.html.markdown
Lines 80 to 82 in af9bceb
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…all content
This can be used to address issue issue #96 and feature request #37. To keep the parent directory, it just must be specified in archive_dir property. archive_dir can have multiple parent levels, if needed. As this uses a new field, it does not regress any current behavior.