Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add source_dirs field #113

Draft
wants to merge 4 commits into
base: main
Choose a base branch
from

Conversation

juliosueiras
Copy link

@juliosueiras juliosueiras commented Aug 20, 2021

Add source_dirs field which would allow archiving multiple dirs at once with the following structure

if dir1 have file1 and dir2 have file2 it would result in this

file1
dir2/file2

terraform example:

data "archive_file" "test-dirs" {
  type = "zip"
  output_path = "test.zip"

  source_dirs {
    root_dirs = [
      "./dir1" # include the content as root level 
    ]
    dirs = [
      "./dir2" # include the folder in the archive
    ]
  }
}

The items need to be for this are adding test cases relate to this and ensure all errors from the filepath walk are return

@hashicorp-cla
Copy link

hashicorp-cla commented Aug 20, 2021

CLA assistant check
All committers have signed the CLA.

@github-actions github-actions bot added size/L and removed size/M labels Aug 20, 2021
@bflad
Copy link
Contributor

bflad commented Sep 2, 2021

Hi @juliosueiras 👋 Thank you for submitting this!

Would you be able to add your intended use case to #37? This will help us with designing the functionality and ensuring that we are covering any expectations.

Thanks!

@bflad bflad added the waiting-response Issues or pull requests waiting for an external response label Sep 2, 2021
@juliosueiras
Copy link
Author

@bflad just want to make sure , is it for me to write how to use this PR to address the use case outline in #37 ?

@jhancock93
Copy link

@juliosueiras, is there any active work going on with this PR? I created #125 which has some similarities.

@github-actions github-actions bot removed the waiting-response Issues or pull requests waiting for an external response label Mar 6, 2022
@AzySir
Copy link
Contributor

AzySir commented Nov 4, 2023

Hi @juliosueiras 👋 Thank you for submitting this!

Would you be able to add your intended use case to #37? This will help us with designing the functionality and ensuring that we are covering any expectations.

Thanks!

@bflad can we accept this functionality - it's so powerful in the "new" world of serverless this is a required function!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants