Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ckeditor to markdown #802

Merged
merged 7 commits into from
Apr 11, 2024
Merged

Ckeditor to markdown #802

merged 7 commits into from
Apr 11, 2024

Conversation

CJGutz
Copy link
Member

@CJGutz CJGutz commented Mar 16, 2024

Remove ckeditor dependency to use Markdown instead.
Changes were made to TOS, Rule, and Item.
Removed ckeditor imports from migrations and replace them with TextField as ckeditor's RichTextField is a type of TextField.
Created a component file which shows a markdown input field with its generated output
All references of ckeditor has been deleted.

@michaelbrusegard
Copy link
Member

@CJGutz I am unable to get this working locally, possibly due to migrations but also most likely due to issues when trying to update the branch with master

@CJGutz
Copy link
Member Author

CJGutz commented Apr 10, 2024

@CJGutz I am unable to get this working locally, possibly due to migrations but also most likely due to issues when trying to update the branch with master

The logs from the github actions errors on a conflicting migration. The migrations need to be in the correct order to run the correct sql to first. The solution is to delete the migration connected to this PR and run makemigrations again. I will do that now

@michaelbrusegard michaelbrusegard merged commit 99e7bad into master Apr 11, 2024
1 check passed
@michaelbrusegard michaelbrusegard deleted the ckeditor-to-markdown branch April 11, 2024 07:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants