Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update django to version 5 #801

Merged
merged 3 commits into from
Apr 3, 2024
Merged

Update django to version 5 #801

merged 3 commits into from
Apr 3, 2024

Conversation

CJGutz
Copy link
Member

@CJGutz CJGutz commented Mar 16, 2024

Updates requirements txt to use django version 5 instead of 3.
Basically only changes to urls, settings, and requirements file.

Should be merged after #802 as ckeditor 4 is deprecated.

@CJGutz CJGutz requested a review from michaelbrusegard March 16, 2024 15:48
@CJGutz CJGutz changed the title Move to django 5 Update django to version 5 Mar 16, 2024
@michaelbrusegard
Copy link
Member

@CJGutz I think we should update to python 12 and pillow 10 at the same time. Are you sure this was all that was needed to make everything work

@CJGutz
Copy link
Member Author

CJGutz commented Mar 16, 2024

Good call. Ill update some others to the latest version. I think that includes bleach and ckeditor as well. From my limited testing of running the website, I have not found any errors.

@@ -308,7 +308,6 @@
)

USE_I18N = True
USE_L10N = True
Copy link
Member Author

@CJGutz CJGutz Apr 3, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Deprecated in django 4

@CJGutz CJGutz requested a review from supattrw April 3, 2024 16:44
Copy link

@supattrw supattrw left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGFM!! :333

@CJGutz CJGutz merged commit 561abc2 into master Apr 3, 2024
1 check passed
@CJGutz CJGutz deleted the move-to-django-5 branch April 3, 2024 16:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants