Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add comments to parser.rs #18

Merged
merged 3 commits into from
Sep 26, 2024
Merged

Add comments to parser.rs #18

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
fc92d11
Add comments to parser.rs
v-jkegler Sep 26, 2024
aadf449
Update parser/src/earley/parser.rs
mmoskal Sep 26, 2024
6dd87a7
Update parser/src/earley/parser.rs
mmoskal Sep 26, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 10 additions & 2 deletions parser/src/earley/parser.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -246,11 +246,14 @@ impl Scratch {
}
}

// Set current working Earley to empty set
// The set backing data is at `pos`
fn new_row(&mut self, pos: usize) {
self.row_start = pos;
self.row_end = pos;
}

// Number of items in the current working Earley set
fn row_len(&self) -> usize {
self.row_end - self.row_start
}
Expand Down Expand Up @@ -480,6 +483,9 @@ impl ParserState {
self.curr_row_bytes().len() > 0
}

// Does the parse succeed in this Earley set?
// That is, does this Earley set contain a completed
// start rule?
fn row_is_accepting(&self) -> bool {
for pos in self.after_dots() {
let after_dot = self.grammar.sym_idx_dot(pos);
Expand Down Expand Up @@ -540,6 +546,8 @@ impl ParserState {
self.lexer_stack[self.lexer_stack.len() - 1]
}

// Current size of the Earley table --
// that is, the number of Earley sets.
#[inline(always)]
pub fn num_rows(&self) -> usize {
self.lexer_state().row_idx as usize + 1
Expand Down Expand Up @@ -1175,7 +1183,7 @@ impl ParserState {
// Agenda retrieval is a simplication of Kallmeyer 2018.
// There is no separate data structure for the agenda --
// the Earley table is used, so that adding to the Earley
// table (aka chart) also adds an item to the agenda, no duplicate
// table (aka chart) also adds an item to the agenda. No duplicate
// agenda items are added. Agenda items are never removed --
// instead 'agenda_ptr' is advanced through the combined agenda/chart.
// Only one pass is made.
Expand Down Expand Up @@ -1244,7 +1252,7 @@ impl ParserState {
}
}
}
} else {
} else { // ... if 'rule' is an incompletion
let sym_data = self.grammar.sym_data(after_dot);
if let Some(lx) = sym_data.lexeme {
allowed_lexemes.set(lx.as_usize(), true);
Expand Down
Loading