Add comments to parser.rs #18
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add comments to parser.rs
mmoskal
reviewed
Sep 26, 2024
mmoskal
reviewed
Sep 26, 2024
|
I did a small fix - new_row() is empty |
|
Good you caught this. And it makes sense that the code should work that way. Thanks!
________________________________
From: Michał Moskal ***@***.***>
Sent: Thursday, September 26, 2024 11:34 AM
To: microsoft/llguidance ***@***.***>
Cc: Jeffrey Kegler (Muse and Gordon Consulting PLLC) ***@***.***>; Author ***@***.***>
Subject: Re: [microsoft/llguidance] Add comments to parser.rs (PR #18)
@mmoskal commented on this pull request.
________________________________
In parser/src/earley/parser.rs<#18 (comment)>:
@@ -246,11 +246,14 @@ impl Scratch {
}
}
+ // Set current working Earley set to the single item
⬇️ Suggested change
- // Set current working Earley set to the single item
+ // Set current working Earley to empty set
—
Reply to this email directly, view it on GitHub<#18 (review)>, or unsubscribe<https://github.com/notifications/unsubscribe-auth/BLFFSVVDDPGUBC77SAL3UFTZYQSRRAVCNFSM6AAAAABO3Z2TWCVHI2DSMVQWIX3LMV43YUDVNRWFEZLROVSXG5CSMV3GSZLXHMZDGMZRGY3TSOJUGI>.
You are receiving this because you authored the thread.Message ID: ***@***.***>
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add comments to parser.rs