Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

upgrade google-protobuf version to fix bundle size issues #1291

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

upgrade google-protobuf version to fix bundle size issues #1291

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion packages/grpc-web/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -30,7 +30,7 @@
"google-closure-compiler": "~20200224.0.0",
"google-closure-deps": "~20210601.0.0",
"google-closure-library": "~20210808.0.0",
"google-protobuf": "~3.14.0",
"google-protobuf": "~3.21.1",
Copy link
Collaborator

@sampajano sampajano Oct 12, 2022 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

btw, since this is only a "devDependencies" and is only used during development, it does not change the final output of the grpc-web npm package (which doesn't depend on google-protobuf directly).

What would make a difference is when developers start depending on [email protected] directly in their client applicaiton, like in our HelloWorld example:

grpc-web/net/grpc/gateway/examples/helloworld/package.json

Line 10 in b0ea9c7

"google-protobuf": "~3.14.0",

"gulp": "~4.0.2",
"gulp-connect": "~5.7.0",
"gulp-eval": "~1.0.0",
Expand Down