upgrade google-protobuf version to fix bundle size issues
#1291
Conversation
Based on this issue: protocolbuffers/protobuf-javascript#124 on google-protobuf the new changes fixed and reduced the bundle size. So here we upgrade `google-protobuf` version to fix bundle size issues
|
|
|
This will close: #270 |
|
@sayjeyhi Hi Jafar, thanks so much your contributions here! Really appreciate your initiative and efforts here! ❤️ Although.. when i just checked bundle size for
I'm guessing it's due to this PR below: I wonder if you have any ideas on the above PR and whether it can be solved? Thanks a lot! |
| @@ -30,7 +30,7 @@ | |||
| "google-closure-compiler": "~20200224.0.0", | |||
| "google-closure-deps": "~20210601.0.0", | |||
| "google-closure-library": "~20210808.0.0", | |||
| "google-protobuf": "~3.14.0", | |||
| "google-protobuf": "~3.21.1", | |||
There was a problem hiding this comment.
btw, since this is only a "devDependencies" and is only used during development, it does not change the final output of the grpc-web npm package (which doesn't depend on google-protobuf directly).
What would make a difference is when developers start depending on [email protected] directly in their client applicaiton, like in our HelloWorld example:
Based on this issue: protocolbuffers/protobuf-javascript#124 on google-protobuf the new changes fixed and reduced the bundle size. So here we upgrade
google-protobufversion to fix bundle size issues.