grpc-js: Implement server interceptors #2650
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is an implementation of gRFC L112, currently in review at grpc/proposal#406. I had to rewrite a lot of the server-side request handling code to accommodate the new API, and I think the result is an improvement.
I changed a couple of existing tests because the previous behavior was incorrect:
OUT_OF_RANGE
status when receiving an invalidgrpc-timeout
value, but the library is not allowed to generate that status, so I changed it toINTERNAL
.The new test file shows a few over-simplified examples of using the server interceptor API.
This fixes #419.