Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

@grpc/grpc-js 1.10.0 instrumentation crashes #2000

Closed
bizob2828 opened this issue Feb 7, 2024 · 1 comment · Fixed by #2001
Closed

@grpc/grpc-js 1.10.0 instrumentation crashes #2000

bizob2828 opened this issue Feb 7, 2024 · 1 comment · Fixed by #2001
Assignees
@bizob2828
Labels
bug needs-triage

Comments

@bizob2828
Copy link
Member

Description

It looks like a refactor occurred where the event listeners we rely on have changed. According to 1.10.0 they provided a new interface to do this in grpc/grpc-node#2650.

Expected Behavior

grpc versioned tests pass on 1.10.0 of library.

Steps to Reproduce

npm run versioned:internal grpc
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@bizob2828 bizob2828

Labels
bug needs-triage
Projects
Node.js Engineering Board
Archived in project
Milestone
No milestone
1 participant
@bizob2828