Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

cleanup: Fix usages of non-constant format strings #7959

Merged
merged 1 commit into from
Dec 23, 2024

Fix usages of non-constant format strings

89ac99e
Select commit
Loading
Failed to load commit list.
Merged

cleanup: Fix usages of non-constant format strings #7959

Fix usages of non-constant format strings
89ac99e
Select commit
Loading
Failed to load commit list.
Codecov / codecov/project succeeded Dec 23, 2024 in 0s

82.22% (+0.18%) compared to f32168c

View this Pull Request on Codecov

82.22% (+0.18%) compared to f32168c

Details

Codecov Report

Attention: Patch coverage is 75.00000% with 1 line in your changes missing coverage. Please review.

Project coverage is 82.22%. Comparing base (f32168c) to head (89ac99e).

Files with missing lines Patch % Lines
stream.go 0.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master    #7959      +/-   ##
==========================================
+ Coverage   82.04%   82.22%   +0.18%     
==========================================
  Files         379      379              
  Lines       38261    38261              
==========================================
+ Hits        31391    31462      +71     
+ Misses       5565     5506      -59     
+ Partials     1305     1293      -12     
Files with missing lines Coverage Δ
internal/transport/handler_server.go 86.46% <100.00%> (ø)
xds/internal/balancer/clusterimpl/picker.go 97.00% <100.00%> (ø)
xds/internal/xdsclient/transport/ads/ads_stream.go 85.37% <100.00%> (+1.31%) ⬆️
stream.go 82.54% <0.00%> (+0.84%) ⬆️

... and 25 files with indirect coverage changes