Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

cleanup: Fix usages of non-constant format strings #7959

Merged
merged 1 commit into from
Dec 23, 2024

Conversation

arjan-bal
Copy link
Contributor

go 1.24 includes a vet rule that catches non-constant format strings: golang/go#60529. This causes go test to fail unless vet is disabled when using go1.24.

RELEASE NOTES: None

@arjan-bal arjan-bal added Type: Internal Cleanup Refactors, etc Area: Testing Includes tests and testing utilities that we have for unit and e2e tests within our repo. labels Dec 23, 2024
@arjan-bal arjan-bal added this to the 1.70 Release milestone Dec 23, 2024
Copy link

codecov bot commented Dec 23, 2024

Codecov Report

Attention: Patch coverage is 75.00000% with 1 line in your changes missing coverage. Please review.

Project coverage is 82.22%. Comparing base (f32168c) to head (89ac99e).
Report is 5 commits behind head on master.

Files with missing lines Patch % Lines
stream.go 0.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master    #7959      +/-   ##
==========================================
+ Coverage   82.04%   82.22%   +0.18%     
==========================================
  Files         379      379              
  Lines       38261    38261              
==========================================
+ Hits        31391    31462      +71     
+ Misses       5565     5506      -59     
+ Partials     1305     1293      -12     
Files with missing lines Coverage Δ
internal/transport/handler_server.go 86.46% <100.00%> (ø)
xds/internal/balancer/clusterimpl/picker.go 97.00% <100.00%> (ø)
xds/internal/xdsclient/transport/ads/ads_stream.go 85.37% <100.00%> (+1.31%) ⬆️
stream.go 82.54% <0.00%> (+0.84%) ⬆️

... and 25 files with indirect coverage changes

@dfawley dfawley assigned arjan-bal and unassigned dfawley Dec 23, 2024
@dfawley dfawley changed the title *: Fix usages of non-constant format strings cleanup: Fix usages of non-constant format strings Dec 23, 2024
@dfawley dfawley merged commit e912015 into grpc:master Dec 23, 2024
15 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Area: Testing Includes tests and testing utilities that we have for unit and e2e tests within our repo. Type: Internal Cleanup Refactors, etc
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants