Fix browser tests in CI #4114
Merged
Fix browser tests in CI #4114
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ubuntu-latest become ubuntu-24.04 and this breaks browser tests for some reason.
mstoykov
force-pushed
the
fixBrowserAfterMerge
branch
from
a5b766a to
f4b1030
Compare
mstoykov
requested review from
inancgumus and
ankur22
and removed request for
a team
mstoykov
changed the title
olegbespalov
previously approved these changes
Dec 16, 2024
It seems like quite a lot of tests are not passing on windows. Unfortunately given the volume fixing them right now seems unlikely. So I opened #4118 This tests have not been ran on windows it seems ever, before the move of the codebase to core.
mstoykov
force-pushed
the
fixBrowserAfterMerge
branch
from
35a4403 to
d149740
Compare
olegbespalov
approved these changes
Dec 16, 2024
There was a problem hiding this comment.
👏 for doing this. However, seems like it's 20-30 more minutes 😢 So maybe it's better to disable all browser tests on windows and re-enable them as part of #4118
ankur22
approved these changes
Dec 16, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What?
Why?
Checklist
make lint) and all checks pass.make tests) and all tests pass.Related PR(s)/Issue(s)