-
Notifications
You must be signed in to change notification settings - Fork 29
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update categories for asset backdrop & sound #1205
Merged
+50
−7
Merged
Changes from all commits
Commits
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1,15 +1,44 @@ | ||
import type { LocaleMessage } from '@/utils/i18n' | ||
import { AssetType } from '@/apis/asset' | ||
|
||
export type Category = { | ||
value: string | ||
message: LocaleMessage | ||
} | ||
|
||
export const categories: Category[] = [ | ||
export const spriteCategories: Category[] = [ | ||
{ value: 'People', message: { en: 'People', zh: '人物' } }, | ||
{ value: 'Animals', message: { en: 'Animals', zh: '动物' } }, | ||
{ value: 'Daily', message: { en: 'Daily', zh: '日常' } }, | ||
{ value: 'Fantasy', message: { en: 'Fantasy', zh: '幻想' } }, | ||
{ value: 'Nature', message: { en: 'Nature', zh: '自然' } }, | ||
{ value: 'UI', message: { en: 'UI', zh: '界面' } } | ||
] | ||
|
||
export const backdropCategories: Category[] = [ | ||
{ value: 'Daily', message: { en: 'Daily', zh: '日常' } }, | ||
{ value: 'Fantasy', message: { en: 'Fantasy', zh: '幻想' } }, | ||
{ value: 'Nature', message: { en: 'Nature', zh: '自然' } }, | ||
{ value: 'UI', message: { en: 'UI', zh: '界面' } } | ||
] | ||
|
||
export const soundCategories: Category[] = [ | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. sound 的分类还没定,先放这俩占位 |
||
// TODO: discussion needed | ||
{ value: 'Daily', message: { en: 'Daily', zh: '日常' } }, | ||
{ value: 'Nature', message: { en: 'Nature', zh: '自然' } } | ||
] | ||
|
||
export function getAssetCategories(type: AssetType): Category[] { | ||
switch (type) { | ||
case AssetType.Sprite: | ||
return spriteCategories | ||
case AssetType.Backdrop: | ||
return backdropCategories | ||
case AssetType.Sound: | ||
return soundCategories | ||
default: | ||
return [] | ||
} | ||
} | ||
|
||
export const categoryAll: Category = { value: '*', message: { en: 'All', zh: '所有' } } |
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
应该是组件
UITag
样式的调整导致这里148px
放不下“Your backdrops”了,目前的实现会挤占右侧的空间,导致每行的数量少了一个跟清清商量了下先把窗口整体宽度增加一些,另外添加
min-width: 0;
确保即使放不下也不会挤占右侧空间