Update categories for asset backdrop & sound #1205
Conversation
|
Skipping CI for Draft Pull Request. |
There was a problem hiding this comment.
Copilot reviewed 3 out of 3 changed files in this pull request and generated no comments.
Comments suppressed due to low confidence (2)
spx-gui/src/components/asset/library/category.ts:26
- [nitpick] The 'TODO' comment indicates that a discussion is needed for sound categories. Ensure this is addressed before merging.
// TODO: discussion needed
spx-gui/src/components/asset/library/AssetAddModal.vue:89
- The error message should be more descriptive. Consider changing it to
unknown asset type: ${props.asset.constructor.name}to include the actual type of the asset.
throw new Error(`unknown asset type ${props.asset}`)
| @@ -233,7 +236,8 @@ async function handleAssetClick(asset: AssetData) { | |||
| justify-content: stretch; | |||
| } | |||
| .sider { | |||
| flex: 0 0 148px; | |||
| flex: 0 0 168px; | |||
There was a problem hiding this comment.
应该是组件 UITag 样式的调整导致这里 148px 放不下“Your backdrops”了，目前的实现会挤占右侧的空间，导致每行的数量少了一个
跟清清商量了下先把窗口整体宽度增加一些，另外添加 min-width: 0; 确保即使放不下也不会挤占右侧空间
|
This PR has been deployed to the preview environment. You can explore it using the preview URL. Warning Please note that deployments in the preview environment are temporary and will be automatically cleaned up after a certain period. Make sure to explore it before it is removed. For any questions, contact the Go+ Builder team. |
| { value: 'UI', message: { en: 'UI', zh: '界面' } } | ||
| ] | ||
|
|
||
| export const soundCategories: Category[] = [ |
Updates #1062 (comment)