-
Notifications
You must be signed in to change notification settings - Fork 816
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Adds Documention for how to run an in-place Agones upgrade #3904
base: main
Are you sure you want to change the base?
Conversation
Build Succeeded 👏 Build Id: bf13e86f-cb31-4dbf-bc9a-7a9eca971e6b The following development artifacts have been built, and will exist for the next 30 days:
A preview of the website (the last 30 builds are retained): To install this version:
|
Build Succeeded 👏 Build Id: 0f3adad3-ed2c-4494-ab0a-598c38feb4f9 The following development artifacts have been built, and will exist for the next 30 days:
A preview of the website (the last 30 builds are retained): To install this version:
|
Build Succeeded 👏 Build Id: ee774e85-48d2-45cf-ae5d-0949b35edbee The following development artifacts have been built, and will exist for the next 30 days:
A preview of the website (the last 30 builds are retained): To install this version:
|
4. Run any other tests to ensure the Agones installation is working as expected. | ||
5. Congratulations - you have now upgraded to a new version of Agones! 👍 | ||
|
||
##### Delay Upgrade to Existing Fleet (not recommended) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why is one recommended over the other?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Do you mean compared to delaying the fleet upgrade, or compared to adding or not adding a label?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Compared to delaying the existing Fleet - we never specify why one is preferred over the other. We should be clear on that (I'm also curious 😆)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Totally legit question! I'll add in a more consise explanation somewhere on the "why".
It's because if the fleet is not ugpraded, none of the game servers are upgraded. Newly created game servers will be at the new configuraiton, but any existing ready game servers, or allocated game servers that return to the ready state will remain at the old configuraiton. This means that the fleet will remain at the old configuration for much longer. In and of itself that's not necessarily a bad thing, but if they do multiple Agones upgrades they could easily end up with several different versions of game servers in a fleet, and limited to no way of tracking which game server is at which version.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I did some rearranging / reordering. The wording or format could probably be clearer. Let me know if you have any additional suggestions!
Build Succeeded 👏 Build Id: fc512a2f-5ea9-4a23-98c5-7ae3a49ffa67 The following development artifacts have been built, and will exist for the next 30 days:
A preview of the website (the last 30 builds are retained): To install this version:
|
Build Succeeded 👏 Build Id: 41fe7c03-3f06-4eeb-a6d2-736be22e4686 The following development artifacts have been built, and will exist for the next 30 days:
A preview of the website (the last 30 builds are retained): To install this version:
|
356582b
to
e05437f
Compare
Build Succeeded 🥳 Build Id: 9778b2fd-7db6-4b88-abec-2771a02438c7 The following development artifacts have been built, and will exist for the next 30 days:
A preview of the website (the last 30 builds are retained): To install this version:
|
1f73c25
to
eb170ca
Compare
Build Succeeded 🥳 Build Id: 1e293a75-e264-4184-bedd-8f27858ff0ac The following development artifacts have been built, and will exist for the next 30 days:
A preview of the website (the last 30 builds are retained): To install this version:
|
0bcca23
to
0759344
Compare
Build Succeeded 🥳 Build Id: 0f88e6b6-130e-47df-bb00-adecda7221d4 The following development artifacts have been built, and will exist for the next 30 days:
A preview of the website (the last 30 builds are retained): To install this version:
|
Build Succeeded 🥳 Build Id: 4015b0a7-1a52-4308-9ab3-52680cc42a4e The following development artifacts have been built, and will exist for the next 30 days:
A preview of the website (the last 30 builds are retained): To install this version:
|
configuration. | ||
2. Any newly created Game Servers will be at the new configuration. | ||
3. This make it difficult to track when the entire fleet is at a new configuration, and | ||
increases the liklihood of having multiple Game Server configurations on the same Fleet. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
liklihood -> likelihood
What type of PR is this?
/kind documentation
What this PR does / Why we need it:
User documentation for how to perform an Agones in-place upgrade.
Which issue(s) this PR fixes:
Working on #3766
Special notes for your reviewer: