Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

charts/timesketch remove deprecated config file #65

Merged
merged 1 commit into from
Sep 29, 2023
Merged

charts/timesketch remove deprecated config file #65

merged 1 commit into from
Sep 29, 2023

Conversation

wajihyassine
Copy link
Member

Description of the change

Hot patch to fix config being removed in latest PR: google/timesketch#2913

Checklist

  • [ x] Chart version bumped in Chart.yaml according to semver. This is not necessary when the changes only affect README.md files.
  • [ x] Variables are documented in the values.yaml and added to the README.md usingreadme-generator-for-helm
  • [ x] Title of the pull request follows this pattern [charts/<name_of_the_chart>] Descriptive title

@wajihyassine
Copy link
Member Author

FYI @jkppr

@wajihyassine wajihyassine mentioned this pull request Sep 29, 2023
Merged
3 tasks
@wajihyassine wajihyassine self-assigned this Sep 29, 2023
@wajihyassine wajihyassine added the bug Something isn't working label Sep 29, 2023
aarontp
aarontp approved these changes Sep 29, 2023
View reviewed changes
Copy link
Member

@aarontp aarontp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@wajihyassine wajihyassine merged commit 55360a4 into main Sep 29, 2023
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@aarontp aarontp aarontp approved these changes

@berggren berggren Awaiting requested review from berggren

Assignees

@wajihyassine wajihyassine

Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@wajihyassine @aarontp