Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

charts/[turbinia/timesketch]Make htmlDate an explicit string #64

Merged
merged 2 commits into from
Sep 29, 2023
Merged

charts/[turbinia/timesketch]Make htmlDate an explicit string #64

merged 2 commits into from
Sep 29, 2023

Conversation

hacktobeer
Copy link
Collaborator

@hacktobeer hacktobeer commented Sep 29, 2023 •
edited
Loading

Description of the change

Applicable issues

Checklist

  • Chart version bumped in Chart.yaml according to semver. This is not necessary when the changes only affect README.md files.
  • Variables are documented in the values.yaml and added to the README.md usingreadme-generator-for-helm
  • Title of the pull request follows this pattern [charts/<name_of_the_chart>] Descriptive title

wajihyassine
wajihyassine reviewed Sep 29, 2023
View reviewed changes
Copy link
Member

@wajihyassine wajihyassine left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for this Ramses! Nitpick, but can you please bump the Timesketch Chart version as well?

Tedious.. but this will definitely change once we have a single chart instead

@wajihyassine
Copy link
Member

Actually disregard will have to update the chart version anyways in #65

@wajihyassine wajihyassine merged commit 0fff20e into google:main Sep 29, 2023
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@wajihyassine wajihyassine wajihyassine left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

unquoted htmlDate function throws error
2 participants
@hacktobeer @wajihyassine