rasterio source module #1115
Merged
rasterio source module #1115
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
but I prefer black
the use og gdal-style transform is depcrecated since rasterio 1.0
banesullivan
commented
May 26, 2023
Comment on lines
+74
to
+76
|
|
||
| *.ipynb | ||
| NOTES.md |
There was a problem hiding this comment.
These are from my dev environment. Maybe remove?
manthey
approved these changes
May 26, 2023
|
Recommend merging as is. Though there will need to be follow-up work to:
Otherwise, this is generally complete |
Each source can define this independently, so that if only one geospatial source is installed, it will still have the ability to prioritize geospatial sources appropriately.
|
@12rambau, thank you for getting this started!! You handled a ton of the legwork and made it possible for us to come in and finalize this. We'll tag a release and this should ship shortly. |
|
🎉 |
|
amazing I was completly unable to finalizing it due to work constraints from my side, I'm super glad you made it ! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Supersedes #927 -- making PR from a dedicated branch in this repo to make my life easier
This branch implements a new tile source module based on rasterio to simplify the usage of geospatial tile sources where installing GDAL might not be easy.
This further refactors some of the existing GDAL and Mapnik tile sources so that they better share a base class of common geospatial code and similarly, the tests for these modules have been refactored to verify that all three source modules produce the same results.
testPixelandtestTileLinearStyleFromGeotiffsintest/test_source_mapnik.py. These are the only two remaining tests with differing results from the GDAL and rasterio sources. The styling for mapnik needs to be fixed (well maybe the styling should be fixed for all sources), then these tests should be removed to let the base class tests run.rgba_geotiff.py: this is a pesky test file -- I will follow up in a separate PR with details on why. Currently only the GDAL source can handle this file and files like it.django-large-iamgeto verify the GDAL source is still in working order and to verify therasteriosource works as expected (still missingTILEDgetRegion()support)Still to address:
large_image.open()may not prefer the new rasterio source