-
Notifications
You must be signed in to change notification settings - Fork 4
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: use localtileserver as native deps #835
Conversation
Codecov Report
@@ Coverage Diff @@
## main #835 +/- ##
==========================================
+ Coverage 96.52% 96.57% +0.05%
==========================================
Files 39 39
Lines 3767 3764 -3
==========================================
- Hits 3636 3635 -1
+ Misses 131 129 -2
|
Thanks for that @12rambau. I have tested it on SEPAL and it works smoothly. |
That's unexpected, is there a |
Localtilelayer sets |
Thanks for finding out, I would go directly to the max value of leaflet basemaps (24) let me update the value and fix the test and I'll request your review again |
It is also forcing me to drop support of Python 3.7 as it's not supported by |
people from kitware and I we finally finished the full rasterio implementation of lagre_image (girder/large_image#1115) which allowed localtileserver to now only depends on rasterio (https://github.com/banesullivan/localtileserver/releases/tag/0.7.0). That's a very good news as it means local images can finally be shown in interactive maps within sepal-ui applications.
In this PR:
for @dfguerrerom:
As SEPAL fall in the "distant jupyter" know dificulties (https://localtileserver.banesullivan.com/installation/remote-jupyter.html), I also imported a proxy generator in the lib. If I'm not wrong you should be able to make everything work by setting the
LOCALTILESERVER_CLIENT_PREFIX
env variable to "/api/sandbox/jupyter/proxy/{port}". I think you will need to work with @cdanielw to add this env variable in every user instances (e.g. in the default .bashrc) so that user get something on their screen without the need to go to their terminal.Let me know if you think I should modify anything, I'm planning on merging it next week.