Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
link EBI data retrieval into the filter/plot/explore #4411
link EBI data retrieval into the filter/plot/explore #4411
Changes from 17 commits
6474bbe
6c456d0
2e65cea
4e96b32
57f6c19
a4dcb64
be45ac6
afc2340
7c1d939
2a7950c
76b212a
ed58e6e
88372d5
b482308
cbb0dd7
98e3c0e
bb6d9fc
ef44a1a
7e5ef83
59df18a
06859e8
9d71842
0132400
1fc24c8
247566a
2450276
1c1bf2c
6256768
8f33254
34f0e92
3e840cf
2a57491
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@wee-snufkin what is broken in the latest version?
Should we hide this latest version?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
That's the error message when I'm running this step with 1.8.1+galaxy93
If it's not a quick fix, we might want to hide the latest version
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This error is fixable. We just need an older numpy version. e.g. numpy==1.21
Can you try this on EU please with the latest version? If this works I will fix the upstream package.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@pcm32 This is a matter of tool developer skills, if I'm not mistaken? Are you able to advise here?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We don't seem to get this error on instances using singularity (although not sure at the exact wrapper version). Those newer versions only have changes in the galaxy wrapper, the dependency had remained the same for a long time I think
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
So what's going on with this? I'm reviewing this following @wee-snufkin instructions in the tutorial to use the older version. If this issue gets fixed, we can update it I guess
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I've copied this discussion over to here so we don't lose it in the merged PR: galaxyproject/tools-iuc#5636