Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

link EBI data retrieval into the filter/plot/explore #4411

Merged

Conversation

wee-snufkin
Copy link
Collaborator

Adding another option for getting data into filter, plot, explore tutorial. Uses EBI data retrieval tool and some data manipulation to integrate well into the tutorial and its workflow.
@nomadscientist

@wee-snufkin wee-snufkin requested a review from a team as a code owner October 12, 2023 08:17
@nomadscientist
Copy link
Collaborator

Hi @wee-snufkin! Exciting!
This tutorial should go into the "Changing data formats & preparing objects" as its own (small) tutorial, rather than in the Filter/plot/explore one itself. Instead, just put a comment in the FPE that the data can be ingested from elsewhere and link to that.

@nomadscientist
Copy link
Collaborator

@Camila-goclowski it will also eventually be good to link this to the Seurat version you're doing

# Conclusion
Now you can use this object as input for the [Filter, Plot, Explore tutorial]({% link topics/single-cell/tutorials/scrna-case_basic-pipeline/tutorial.md %}) and its associated workflow!

Even though this tutorial was designed specifically to modify the AnnData object to be compatible with the subsequent tutorial, it also shows useful tools that you can use for your own, independent data analysis. You can find the [workflow]() and the [answer key history](). However, if you want to use the workflow from this tutorial, you have to keep in mind that different datasets may have different column names. So you have to check them first, and only then you can modify them.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Here is something missing [workflow]() and the [answer key history]()

@@ -108,6 +108,12 @@ You can access the data for this tutorial in multiple ways:
>
{: .hands_on}

4. **Importing data from EBI Single Cell Expression Atlas**

You can also pull the data from publicly available [Single Cell Expression Atlas](https://www.ebi.ac.uk/gxa/sc/home). You can simply access the dataset we are working on by using the tool *EBI SCXA Data Retrieval* with experiment id of [E-MTAB-6945](https://www.ebi.ac.uk/gxa/sc/experiments/E-MTAB-6945/downloads). This [short tutorial]() will show you how to use this tool and modify the output so that it's compatible with this tutorial and its workflow.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

here as well [short tutorial]()

@wee-snufkin
Copy link
Collaborator Author

Thanks @bgruening, I'll fill the links once EBI retrieval tool starts working again and allows me to generate the final history and workflow!

@bgruening
Copy link
Member

@wee-snufkin can I help to fix the tool?

@wee-snufkin
Copy link
Collaborator Author

@wee-snufkin can I help to fix the tool?

It's all sorted! :)

>
>
> 1. {% tool [Scanpy Read10x](toolshed.g2.bx.psu.edu/repos/ebi-gxa/scanpy_read_10x/scanpy_read_10x/1.8.1+galaxy9) %}
> 2. Make sure you are using version **1.8.1+galaxy9** of the tool (change by clicking on {% icon tool-versions %} Versions button):
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@wee-snufkin what is broken in the latest version?

Should we hide this latest version?

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That's the error message when I'm running this step with 1.8.1+galaxy93
image

If it's not a quick fix, we might want to hide the latest version

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This error is fixable. We just need an older numpy version. e.g. numpy==1.21

Can you try this on EU please with the latest version? If this works I will fix the upstream package.

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@pcm32 This is a matter of tool developer skills, if I'm not mistaken? Are you able to advise here?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We don't seem to get this error on instances using singularity (although not sure at the exact wrapper version). Those newer versions only have changes in the galaxy wrapper, the dependency had remained the same for a long time I think

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

So what's going on with this? I'm reviewing this following @wee-snufkin instructions in the tutorial to use the older version. If this issue gets fixed, we can update it I guess

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I've copied this discussion over to here so we don't lose it in the merged PR: galaxyproject/tools-iuc#5636

pavanvidem
pavanvidem previously approved these changes Nov 13, 2023
Copy link
Member

@pavanvidem pavanvidem left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me.

topics/single-cell/tutorials/EBI-retrieval/tutorial.md Outdated Show resolved Hide resolved
Co-authored-by: Pavankumar Videm <[email protected]>
Copy link
Collaborator

@nomadscientist nomadscientist left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The workflow + workflow testing will need minor updates based on how there's now the Seurat option, and the tool versioning on the Scanpy tools is still an issue, but as it's written the tutorial runs well now!

@nomadscientist nomadscientist merged commit 42c7dcd into galaxyproject:main Nov 14, 2023
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants