-
Notifications
You must be signed in to change notification settings - Fork 443
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Explicitly set tmp dir for fasterq-dump #5863
Explicitly set tmp dir for fasterq-dump #5863
Conversation
@@ -2,6 +2,7 @@ | |||
<description>format from NCBI SRA</description> | |||
<macros> | |||
<import>macros.xml</import> | |||
<token name="VERSION_SUFFIX">1</token> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Does this "overwrite" the token in macros.xml?
Is this a good idea?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
yes. why should we bump every tool if only one has changed ?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I understand the argument, but IMO this is easily missed when updating the macros.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Isn't that handled by the bot ? What's the process to just bump one tool ?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sometimes people bump manually :)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
ok, so now what ? I can drop @VERSION_SUFFIX@
and put a literal 1 if that's any better
This comment was marked as outdated.
This comment was marked as outdated.
Seems that this did not work. At least the toolshed still reports this as |
FOR CONTRIBUTOR: