Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixes for grep tool #1413

Merged
merged 4 commits into from
Mar 28, 2024
Merged

Fixes for grep tool #1413

merged 4 commits into from
Mar 28, 2024

Conversation

bernt-matthias
Copy link
Collaborator

fixes #1412

@bernt-matthias bernt-matthias marked this pull request as draft March 27, 2024 16:52
@bernt-matthias bernt-matthias changed the title Fixes fror grep tool Fixes for grep tool Mar 27, 2024
@bernt-matthias bernt-matthias marked this pull request as ready for review March 27, 2024 22:24
@@ -6,7 +6,7 @@
</requirements>
</xml>
<token name="@TOOL_VERSION@">9.3</token>
<token name="@VERSION_SUFFIX@">0</token>
<token name="@VERSION_SUFFIX@">1</token>
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this will bump all tools not just the grep tool

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I know :) But does it make a difference?

It's a single repository containing all tools anyway, or? So bumping one will push all to the toolshed anyway? At least that is what happened here. Also Galaxy servers can only install all tools as a bundle. The tools can not be installed separately. Not sure about updates .. shed_tools/toolshed.g2.bx.psu.edu/repos/bgruening/text_processing/d698c222f354/text_processing

But also if defined as a suite this would be my preference over likely forgetting to reset the suffix of the single tool when the whole suite is updated (manually .. don't know if autoupdate takes care or just resets the token).

@bgruening
Copy link
Owner

Ok, lets ship it!

@bgruening bgruening merged commit c4f50d1 into bgruening:master Mar 28, 2024
14 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

New version of grep fails if pattern isn't found
2 participants