Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix kraken2tax requirements and add test #612

Merged
merged 2 commits into from
Sep 29, 2023
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
14 changes: 7 additions & 7 deletions .github/workflows/pr.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -164,16 +164,16 @@ jobs:
strategy:
matrix:
os: [ubuntu-20.04]
r-version: ['4.0.1']
r-version: ['release']
steps:
- uses: actions/checkout@v2
- uses: actions/checkout@v3
with:
fetch-depth: 1
- uses: r-lib/actions/setup-r@master
- uses: r-lib/actions/setup-r@v2
with:
r-version: ${{ matrix.r-version }}
- name: Cache R packages
uses: actions/cache@v2
uses: actions/cache@v3
with:
path: ${{ env.R_LIBS_USER }}
key: r_cache_${{ matrix.os }}_${{ matrix.r-version }}
Expand All @@ -189,7 +189,7 @@ jobs:
- name: lintr
run: |
library(lintr)
linters <- with_defaults(line_length_linter = NULL, cyclocomp_linter = NULL, object_usage_linter = NULL)
linters <- linters_with_defaults(line_length_linter = NULL, cyclocomp_linter = NULL, object_usage_linter = NULL)
con <- file("repository_list.txt", "r")
status <- 0
while (TRUE) {
Expand All @@ -202,8 +202,8 @@ jobs:
status <- 1
for (l in lnt) {
rel_path <- paste(repo, l$filename, sep="/")
write(paste(paste(rel_path, l$line_number, l$column_number, sep=":"), l$message), stderr())
write(paste(paste(rel_path, l$line_number, l$column_number, sep=":"), l$message), "rlint_report.txt", append=TRUE)
write(paste(paste(rel_path, l$line_number, l$column_number, sep=":"), l$message, paste("(", l$line, ")")), stderr())
write(paste(paste(rel_path, l$line_number, l$column_number, sep=":"), l$message, paste("(", l$line, ")")), "rlint_report.txt", append=TRUE)
}
}
}
Expand Down
1 change: 0 additions & 1 deletion .tt_skip
Original file line number Diff line number Diff line change
Expand Up @@ -4,7 +4,6 @@ tool_collections/hgv/hgv_hilbertvis
tool_collections/hgv/snpfreq
tool_collections/taxonomy/find_diag_hits
tool_collections/taxonomy/gi2taxonomy
tool_collections/taxonomy/kraken2tax
tool_collections/taxonomy/lca_wrapper
tool_collections/taxonomy/poisson2test
tool_collections/taxonomy/t2ps
Expand Down
6 changes: 3 additions & 3 deletions tool_collections/taxonomy/kraken2tax/kraken2tax.xml
Original file line number Diff line number Diff line change
@@ -1,8 +1,8 @@
<tool id="Kraken2Tax" name="Convert Kraken" version="1.2">
<tool id="Kraken2Tax" name="Convert Kraken" version="1.2+galaxy0">
<description>data to Galaxy taxonomy representation</description>
<requirements>
<requirement type="package" version="4.1.0">gawk</requirement>
<requirement type="package" version="1.0.0">gb_taxonomy_tools</requirement>
<requirement type="package" version="5.1.0">gawk</requirement>
<requirement type="package" version="1.0.1">gb_taxonomy_tools</requirement>
</requirements>
<command>
<![CDATA[
Expand Down
3,416 changes: 1 addition & 3,415 deletions tool_collections/taxonomy/kraken2tax/test-data/kraken2tax-test1.txt

Large diffs are not rendered by default.

3,414 changes: 0 additions & 3,414 deletions tool_collections/taxonomy/kraken2tax/test-data/kraken2tax.txt

Large diffs are not rendered by default.

Original file line number Diff line number Diff line change
@@ -0,0 +1,2 @@
#value #name path
test test ${__HERE__}/tax_dir
20 changes: 20 additions & 0 deletions tool_collections/taxonomy/kraken2tax/test-data/tax_dir/names.dmp
Original file line number Diff line number Diff line change
@@ -0,0 +1,20 @@
1 | all | | synonym |
1 | root | | scientific name |
2 | Bacteria | Bacteria <prokaryote> | scientific name |
2 | Monera | Monera <Bacteria> | in-part |
2 | Procaryotae | Procaryotae <Bacteria> | in-part |
2 | Prokaryota | Prokaryota <Bacteria> | in-part |
2 | Prokaryotae | Prokaryotae <Bacteria> | in-part |
2 | bacteria | bacteria <blast2> | blast name |
2 | eubacteria | | genbank common name |
2 | not Bacteria Haeckel 1894 | | synonym |
2 | prokaryote | prokaryote <Bacteria> | in-part |
2 | prokaryotes | prokaryotes <Bacteria> | in-part |
6 | Azorhizobium | | scientific name |
6 | Azorhizobium Dreyfus et al. 1988 emend. Lang et al. 2013 | | authority |
6 | Azotirhizobium | | misspelling |
7 | ATCC 43989 | | type material |
7 | Azorhizobium caulinodans | | scientific name |
7 | Azorhizobium caulinodans Dreyfus et al. 1988 | | synonym |
7 | Azotirhizobium caulinodans | | equivalent name |
7 | CCUG 26647 | | type material |
Original file line number Diff line number Diff line change
@@ -0,0 +1,4 @@
1 | 1 | no rank | | 8 | 0 | 1 | 0 | 0 | 0 | 0 | 0 | |
2 | 2 | superkingdom | | 0 | 0 | 11 | 0 | 0 | 0 | 0 | 0 | |
6 | 6 | genus | | 0 | 1 | 11 | 1 | 0 | 1 | 0 | 0 | |
7 | 7 | species | AC | 0 | 1 | 11 | 1 | 0 | 1 | 1 | 0 | |
Original file line number Diff line number Diff line change
@@ -0,0 +1,8 @@
<?xml version="1.0"?>
<tables>
<!-- Locations of Kraken database in the required format -->
<table name="ncbi_taxonomy" comment_char="#">
<columns>value, name, path</columns>
<file path="${__HERE__}/test-data/ncbi_taxonomy.loc.test" />
</table>
</tables>