Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix kraken2tax requirements and add test #612

Merged
merged 2 commits into from
Sep 29, 2023

Conversation

mvdbeek
Copy link
Member

@mvdbeek mvdbeek commented Feb 22, 2023

No description provided.

@nsoranzo
Copy link
Member

Should this tool be migrated to tools-iuc?

@mvdbeek
Copy link
Member Author

mvdbeek commented Feb 22, 2023

What's the advantage ? I think these low-priority, not-frequrently-updated tools can live here

@mvdbeek
Copy link
Member Author

mvdbeek commented Feb 22, 2023

I see now what the advantage is, but I think it's a nice motivation for galaxyproject/planemo-ci-action#43 and community tool repos in general.

@nsoranzo
Copy link
Member

Also we don't test this repo before a new Galaxy release, which won't be "fixed" by reusable workflows.

@mvdbeek
Copy link
Member Author

mvdbeek commented Feb 22, 2023

Also we don't test this repo before a new Galaxy release, which won't be "fixed" by reusable workflows.

We do, it's in the release process. I've just not done it recently.

@mvdbeek
Copy link
Member Author

mvdbeek commented Feb 22, 2023

Actually, neither IUC nor devteam repo tests are part of the "official" release process. We don't do that for e.g bjoern's tools either, i don't think that should be a criterium one way or the other.

@nsoranzo nsoranzo merged commit 45d0409 into galaxyproject:main Sep 29, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants