Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add reusable workflows #43

Open
wants to merge 21 commits into
base: main
Choose a base branch
from

Conversation

bernt-matthias
Copy link
Collaborator

@bernt-matthias bernt-matthias commented Feb 9, 2023

  • can we reuse the workflows also in the setup-pr-tools job of .github/workflows/tools.yaml .. problem is that I don't know yet how to deal with th extra steps, like the test bumps of the tools (which we would need to do in an extra job)
  • not sure yet if calling the action with uses: ${{ planemo-ci-action }} is possible (which is called in the tests over here with planemo-ci-action: ./ .. I guess this is only useful for testing here)
    • seems that this can be circumvented by calling the action with ./ (i.e. the action is called in the same version as the workflow). Not sure yet how to make sure that this is correct (i.e. local pull requests use the action from the same branch and remote calls to workflow@vX use action@vX )
  • in setup planemo-default-version -> planemo-version
  • documentation

in the called workflows in order to make it useable in the
tests running here. where we do not use

```
uses: galaxyproject/planemo-ci-action@v1
```

but

```
uses: ./
```
and add statistics output to test workflow
This reverts commit 56ab325.

impossible, because we can not use `uses: ${{ planemo-ci-action }}`

lets see if `uses: ./` just does the intended
hoping that:

- tests in this repo will use the action of the PR branch
  (the workflow version ./ is used .. so hopefully also the
   action ./ is used)
- external callers will use the workflows with
  `galaxyproject/planemo-ci-action/.github/workflows/...@vX`
  and I hope that this also yields version X of the action
@bernt-matthias bernt-matthias force-pushed the topic/reusable-workflows branch from 1ec37df to 37c4df9 Compare February 10, 2023 10:17
@bernt-matthias bernt-matthias force-pushed the topic/reusable-workflows branch 2 times, most recently from e86fedc to b4c1945 Compare February 10, 2023 15:25
@bernt-matthias bernt-matthias force-pushed the topic/reusable-workflows branch from 01d73c0 to da49d19 Compare February 11, 2023 12:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant