-
Notifications
You must be signed in to change notification settings - Fork 5
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add reusable workflows #43
Open
bernt-matthias
wants to merge
21
commits into
galaxyproject:main
Choose a base branch
from
bernt-matthias:topic/reusable-workflows
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Add reusable workflows #43
bernt-matthias
wants to merge
21
commits into
galaxyproject:main
from
bernt-matthias:topic/reusable-workflows
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
in the called workflows in order to make it useable in the tests running here. where we do not use ``` uses: galaxyproject/planemo-ci-action@v1 ``` but ``` uses: ./ ```
and add statistics output to test workflow
This reverts commit 56ab325. impossible, because we can not use `uses: ${{ planemo-ci-action }}` lets see if `uses: ./` just does the intended
hoping that: - tests in this repo will use the action of the PR branch (the workflow version ./ is used .. so hopefully also the action ./ is used) - external callers will use the workflows with `galaxyproject/planemo-ci-action/.github/workflows/...@vX` and I hope that this also yields version X of the action
bernt-matthias
force-pushed
the
topic/reusable-workflows
branch
from
February 10, 2023 10:17
1ec37df
to
37c4df9
Compare
bernt-matthias
force-pushed
the
topic/reusable-workflows
branch
2 times, most recently
from
February 10, 2023 15:25
e86fedc
to
b4c1945
Compare
linter complains otherwise
bernt-matthias
force-pushed
the
topic/reusable-workflows
branch
from
February 11, 2023 12:10
01d73c0
to
da49d19
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
setup-pr-tools
job of .github/workflows/tools.yaml .. problem is that I don't know yet how to deal with th extra steps, like the test bumps of the tools (which we would need to do in an extra job)uses: ${{ planemo-ci-action }}
is possible (which is called in the tests over here withplanemo-ci-action: ./
.. I guess this is only useful for testing here)planemo-default-version
->planemo-version