Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Migrate NGL viewer to npm package #18946

Merged
merged 11 commits into from
Oct 18, 2024
Merged

Migrate NGL viewer to npm package #18946

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
11 commits
Select commit Hold shift + click to select a range
5e205ad
Remove ngl code files
guerler Sep 24, 2024
63019c0
Remove ngl from static build plugin ids
guerler Sep 24, 2024
cb98b63
Link ngl source directly from repo
guerler Sep 24, 2024
7710bb4
Install ngl from npm package
guerler Oct 6, 2024
b2d7fe3
Add package.json
guerler Oct 6, 2024
841e235
Strip unnecessary assets sub-directory
guerler Oct 6, 2024
ed1013c
Remove package json
guerler Oct 9, 2024
1d3e6fe
Remove logo from ngl package, update version
guerler Oct 15, 2024
eefc860
Update to version 0.0.7, adjust entrypoints.
dannon Oct 15, 2024
2a68691
Update @galaxyproject/ngl to 0.0.8 with fixed dependencies
dannon Oct 15, 2024
d489cc1
Revert back to explicitly pre-staging static, though per discussions …
dannon Oct 15, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 1 addition & 2 deletions client/gulpfile.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -26,7 +26,6 @@ const STATIC_PLUGIN_BUILD_IDS = [
"jqplot/jqplot_bar",
"media_player",
"mvpapp",
"ngl",
"nora",
"nvd3/nvd3_bar",
"openlayers",
Expand All @@ -39,7 +38,7 @@ const STATIC_PLUGIN_BUILD_IDS = [
"ts_visjs",
"venn",
];
const INSTALL_PLUGIN_BUILD_IDS = ["msa"]; // todo: derive from XML
const INSTALL_PLUGIN_BUILD_IDS = ["ngl", "msa"]; // todo: derive from XML
const DIST_PLUGIN_BUILD_IDS = ["new_user"];
const PLUGIN_BUILD_IDS = Array.prototype.concat(DIST_PLUGIN_BUILD_IDS, STATIC_PLUGIN_BUILD_IDS);

Expand Down
10 changes: 5 additions & 5 deletions config/plugins/visualizations/example/config/example.xml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -20,13 +20,13 @@
<type>setting_type</type>
</input>
</settings>
<groups>
<tracks>
<input>
<name>group_input</name>
<help>group help</help>
<type>group_type</type>
<name>track_input</name>
<help>track help</help>
<type>track_type</type>
</input>
</groups>
</tracks>
<specs>
<spec_name>spec_value</spec_name>
</specs>
Expand Down
5 changes: 4 additions & 1 deletion config/plugins/visualizations/ngl/config/ngl.xml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -12,7 +12,10 @@
<params>
<param type="dataset" var_name_in_template="hda" required="true">dataset_id</param>
</params>
<entry_point entry_point_type="chart" src="dist/ngl.js"/>
<requirements>
<requirement type="npm" version="0.0.8" package="@galaxyproject/ngl"/>
</requirements>
<entry_point entry_point_type="script" src="dist/index.js" css="dist/index.css" />
<settings>
<input>
<label>Quality</label>
Expand Down
23 changes: 0 additions & 23 deletions config/plugins/visualizations/ngl/package.json
View file
Open in desktop

This file was deleted.

48 changes: 0 additions & 48 deletions config/plugins/visualizations/ngl/src/ngl.js
View file
Open in desktop

This file was deleted.

30 changes: 0 additions & 30 deletions config/plugins/visualizations/ngl/src/viewer.js
View file
Open in desktop

This file was deleted.

Loading