Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Migrate NGL viewer to npm package #18946

Merged
merged 11 commits into from
Oct 18, 2024
Merged

Migrate NGL viewer to npm package #18946

merged 11 commits into from
Oct 18, 2024

Conversation

guerler
Copy link
Contributor

@guerler guerler commented Oct 6, 2024

This PR replaces the Galaxy dependent backbone-based charts-ngl plugin with a separate npm package using the Vue3-based charts package.

image

How to test the changes?

(Select all options that apply)

  • I've included appropriate automated tests.
  • This is a refactoring of components with existing test coverage.
  • Instructions for manual testing are as follows:
    1. [add testing steps and prerequisites here if you didn't write automated tests covering all your changes]

License

  • I agree to license these and all my past contributions to the core galaxy codebase under the MIT license.

@guerler guerler added this to the 24.2 milestone Oct 6, 2024
@guerler guerler marked this pull request as ready for review October 6, 2024 10:58
client/gulpfile.js Outdated Show resolved Hide resolved
@guerler
Copy link
Contributor Author

guerler commented Oct 17, 2024

Thank you @dannon for helping with this project. This looks gtm +1.

Copy link
Member

@bgruening bgruening left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This works for me flawlessly! Its always cool to see proteins spinning :)

@dannon
Copy link
Member

dannon commented Oct 18, 2024

I think there are a few things we want to adjust with the published version of the chart, but this is a good step forward for the ngl viewer specifically in any event using the new publishing/installation mechanisms -- going to go ahead and merge this iteration in.

@dannon dannon merged commit c5d89e5 into galaxyproject:dev Oct 18, 2024
51 of 53 checks passed
Copy link

This PR was merged without a "kind/" label, please correct.

@guerler guerler deleted the add_ngl branch October 18, 2024 15:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants