Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fyle Card <> Vendor Mapping setup #181

Merged
merged 10 commits into from
Jun 10, 2024
Merged

Conversation

Hrishabh17
Copy link
Contributor

No description provided.

Copy link

coderabbitai bot commented Jun 3, 2024

Important

Review skipped

Auto reviews are disabled on base/target branches other than the default branch.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.


Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

Share
Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>.
    • Generate unit testing code for this file.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai generate unit testing code for this file.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai generate interesting stats about this repository and render them as a table.
    • @coderabbitai show all the console.log statements in this repository.
    • @coderabbitai read src/utils.ts and generate unit testing code.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
    • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (invoked as PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai full review to do a full review from scratch and review all the files again.
  • @coderabbitai summary to regenerate the summary of the PR.
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
  • @coderabbitai help to get help.

Additionally, you can add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.

CodeRabbit Configration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • Please see the configuration documentation for more information.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

Copy link

github-actions bot commented Jun 3, 2024

Tests Skipped Failures Errors Time
130 0 💤 0 ❌ 0 🔥 9.926s ⏱️

Copy link

github-actions bot commented Jun 3, 2024

Tests Skipped Failures Errors Time
130 0 💤 0 ❌ 0 🔥 10.350s ⏱️

Copy link

github-actions bot commented Jun 4, 2024

Tests Skipped Failures Errors Time
130 0 💤 0 ❌ 0 🔥 9.957s ⏱️

Copy link

github-actions bot commented Jun 4, 2024

Tests Skipped Failures Errors Time
131 0 💤 0 ❌ 12 🔥 9.438s ⏱️

Copy link

github-actions bot commented Jun 4, 2024

Tests Skipped Failures Errors Time
131 0 💤 0 ❌ 0 🔥 9.962s ⏱️

Copy link

github-actions bot commented Jun 5, 2024

Tests Skipped Failures Errors Time
131 0 💤 0 ❌ 0 🔥 9.935s ⏱️

@codecov-commenter
Copy link

Codecov Report

Attention: Patch coverage is 98.48485% with 1 line in your changes missing coverage. Please review.

Please upload report for BASE (refactor-deps-import@1c2e3c1). Learn more about missing BASE report.

Files Patch % Lines
apps/workspaces/serializers.py 50.00% 1 Missing ⚠️
Additional details and impacted files
@@                   Coverage Diff                   @@
##             refactor-deps-import     #181   +/-   ##
=======================================================
  Coverage                        ?   94.70%           
=======================================================
  Files                           ?      100           
  Lines                           ?     5437           
  Branches                        ?        0           
=======================================================
  Hits                            ?     5149           
  Misses                          ?      288           
  Partials                        ?        0           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link

github-actions bot commented Jun 5, 2024

Tests Skipped Failures Errors Time
131 0 💤 0 ❌ 0 🔥 9.917s ⏱️

Copy link

github-actions bot commented Jun 5, 2024

Tests Skipped Failures Errors Time
131 0 💤 0 ❌ 0 🔥 10.019s ⏱️

Copy link

github-actions bot commented Jun 5, 2024

Tests Skipped Failures Errors Time
131 0 💤 0 ❌ 0 🔥 10.036s ⏱️

@Hrishabh17 Hrishabh17 changed the base branch from refactor-deps-import to master June 5, 2024 14:30
@Hrishabh17 Hrishabh17 changed the base branch from master to refactor-deps-import June 10, 2024 05:55
@Hrishabh17 Hrishabh17 merged commit ba304b8 into refactor-deps-import Jun 10, 2024
2 of 3 checks passed
Hrishabh17 added a commit that referenced this pull request Jun 11, 2024
* Delete purchase_invoice, line_items on failed exports from hh2, type-check for current_state

* Refactor deps schedule to run post Job import

* Remove dep setting trigger, add logger

* Remove mock object

* Add details while logging

* Fyle Card <> Vendor Mapping setup (#181)

* Fyle Card <> Vendor Mapping setup

* Added script to add mapping_settings

* Fix post release script

* Modified script, added additional test case

* lint fix

* modify post-release script

* Disable sage fields (#183)

* Fyle Card <> Vendor Mapping setup

* Added script to add mapping_settings

* Fix post release script

* Projects and Deps fields disable v1

* Modified script, added additional test case

* lint fix

* modify post-release script

* bump accounting-mapping version

* modify the variable_name, add conditional update

* Add example objects

* Added loggers

* Added test cases

* Modify test case, add filter in dep field settings

* Dependent Field optimizations (#185)

* Fyle Card <> Vendor Mapping setup

* Added script to add mapping_settings

* Fix post release script

* Projects and Deps fields disable v1

* Modified script, added additional test case

* lint fix

* modify post-release script

* bump accounting-mapping version

* modify the variable_name, add conditional update

* Add example objects

* Added loggers

* Added test cases

* Dependent Field optimizations

* fix failing test

* Fix post-release script

* Fix the merged issues

* Add filters and change log
Hrishabh17 added a commit that referenced this pull request Jun 14, 2024
* Delete purchase_invoice, line_items on failed exports from hh2, type-check for current_state

* Refactor deps schedule to run post Job import

* Remove dep setting trigger, add logger

* Remove mock object

* Add details while logging

* Fyle Card <> Vendor Mapping setup (#181)

* Fyle Card <> Vendor Mapping setup

* Added script to add mapping_settings

* Fix post release script

* Modified script, added additional test case

* lint fix

* modify post-release script

* Disable sage fields (#183)

* Fyle Card <> Vendor Mapping setup

* Added script to add mapping_settings

* Fix post release script

* Projects and Deps fields disable v1

* Modified script, added additional test case

* lint fix

* modify post-release script

* bump accounting-mapping version

* modify the variable_name, add conditional update

* Add example objects

* Added loggers

* Added test cases

* Modify test case, add filter in dep field settings

* Dependent Field optimizations (#185)

* Fyle Card <> Vendor Mapping setup

* Added script to add mapping_settings

* Fix post release script

* Projects and Deps fields disable v1

* Modified script, added additional test case

* lint fix

* modify post-release script

* bump accounting-mapping version

* modify the variable_name, add conditional update

* Add example objects

* Added loggers

* Added test cases

* Dependent Field optimizations

* fix failing test

* Fix post-release script

* Fix the merged issues

* Add filters and change log

* Added script for disabling cost_code and cost_category

* reorder the script

* add rollback begin
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants