Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: View mileage summary card display exact amount #3347

Merged
merged 2 commits into from
Dec 13, 2024

Conversation

SahilK-027
Copy link
Contributor

@SahilK-027 SahilK-027 commented Dec 13, 2024

Clickup

clickup link

UI Preview

Screenshot 2024-12-13 at 11 47 31 AM Screenshot 2024-12-13 at 11 47 24 AM

Summary by CodeRabbit

  • New Features

    • Enhanced display of expense amounts with improved formatting.
    • Introduced a new container for better organization of amount details.
  • Bug Fixes

    • Adjusted visibility of elements based on expense properties and user permissions.
  • Style

    • Updated color properties and font sizes for various elements.
    • Added a new class for the amount container to improve layout.

Copy link

coderabbitai bot commented Dec 13, 2024

Walkthrough

The changes in this pull request involve modifications to the HTML and SCSS files of the view-mileage component. The HTML now uses the exactCurrency pipe for amount formatting, omitting the currency symbol and improving the layout with a new container class. The SCSS file features updates to color properties, font sizes, and the introduction of a new class for the amount container, enhancing the overall styling and organization of the component.

Changes

File Change Summary
src/app/fyle/view-mileage/view-mileage.page.html Restructured amount display using exactCurrency pipe; added new container for amount; adjusted conditional rendering based on expense properties.
src/app/fyle/view-mileage/view-mileage.page.scss Updated color properties and font sizes; added new &__amount-container class; removed margin-top from &--state-pill and deleted &--with-project.

Possibly related PRs

Suggested labels

size/M

Suggested reviewers

  • Dimple16

In the world of mileage, changes take flight,
With amounts now shining, oh what a sight!
ExactCurrency leads the way,
In style and clarity, it’s here to stay.
With colors and sizes all in line,
This UI’s now truly divine! 🌟


Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

❤️ Share
🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>, please review it.
    • Generate unit testing code for this file.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai generate unit testing code for this file.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
    • @coderabbitai read src/utils.ts and generate unit testing code.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
    • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai full review to do a full review from scratch and review all the files again.
  • @coderabbitai summary to regenerate the summary of the PR.
  • @coderabbitai generate docstrings to generate docstrings for this PR. (Experiment)
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
  • @coderabbitai help to get help.

Other keywords and placeholders

  • Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
  • Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
  • Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • Please see the configuration documentation for more information.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

@github-actions github-actions bot added the size/S Small PR label Dec 13, 2024
Copy link

@coderabbitai coderabbitai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 2

📜 Review details

Configuration used: CodeRabbit UI
Review profile: ASSERTIVE
Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between aa39031 and 0495fdb.

📒 Files selected for processing (2)
  • src/app/fyle/view-mileage/view-mileage.page.html (1 hunks)
  • src/app/fyle/view-mileage/view-mileage.page.scss (3 hunks)
🔇 Additional comments (3)
src/app/fyle/view-mileage/view-mileage.page.scss (2)

49-49: Mind it! These color changes are perfect, like my signature style!

The switch from lighter to stronger colors enhances readability. That's how I like it - bold and clear!

Also applies to: 63-63


78-83: When I do something, I do it with style! This container class is superb!

The flex layout with proper gap and alignment - that's how you handle UI elements with precision!

src/app/fyle/view-mileage/view-mileage.page.html (1)

62-62: Now that's what I call precision! The exactCurrency pipe shows the true power of numbers!

The switch to exactCurrency pipe with skipSymbol ensures accurate amount display without redundant currency symbol. Perfect execution!

Copy link

@coderabbitai coderabbitai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 1

📜 Review details

Configuration used: CodeRabbit UI
Review profile: ASSERTIVE
Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 0495fdb and 30184f3.

📒 Files selected for processing (1)
  • src/app/fyle/view-mileage/view-mileage.page.scss (3 hunks)
🔇 Additional comments (2)
src/app/fyle/view-mileage/view-mileage.page.scss (2)

49-49: Mind it! These color changes are simply superb!

The new color scheme brings better contrast and readability. Just like how I make grand entrances in my movies, these colors make the information stand out magnificently!

Also applies to: 63-63, 73-73


86-86: Listen here, partner! The font size needs more power!

16px might be too small for some users to read comfortably. Consider keeping it at 20px for better visibility, especially for mobile users.

-      font-size: 16px;
+      font-size: 20px;

Also applies to: 88-88

Copy link

Unit Test Coverage % values
Statements 96.03% ( 19280 / 20075 )
Branches 91.14% ( 10656 / 11691 )
Functions 94.38% ( 5737 / 6078 )
Lines 96.08% ( 18410 / 19161 )

1 similar comment
Copy link

Unit Test Coverage % values
Statements 96.03% ( 19280 / 20075 )
Branches 91.14% ( 10656 / 11691 )
Functions 94.38% ( 5737 / 6078 )
Lines 96.08% ( 18410 / 19161 )

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
size/S Small PR
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants