feat: View expense summary card display exact amount

[SahilK-027]

Clickup

click up link

UI Preview

Please add screenshots for UI changes

Summary by CodeRabbit

• New Features

  • Enhanced display of project-related and card transaction details in the expense view.
  • Updated formatting for expense amounts to improve clarity.

• Bug Fixes

  • Streamlined rendering logic for displaying expense data.

• Style

  • Adjusted alignment and spacing for improved layout and readability.
  • Modified font sizes for better visual hierarchy in the expense view.

[coderabbitai]

Warning

Rate limit exceeded

@SahilK-027 has exceeded the limit for the number of commits or files that can be reviewed per hour. Please wait 6 minutes and 10 seconds before requesting another review.

⌛ How to resolve this issue?

After the wait time has elapsed, a review can be triggered using the @coderabbitai review command as a PR comment. Alternatively, push new commits to this PR.

We recommend that you space out your commits to avoid hitting the rate limit.

🚦 How do rate limits work?

CodeRabbit enforces hourly rate limits for each developer per organization.

Our paid plans have higher rate limits than the trial, open-source and free plans. In all cases, we re-allow further reviews after a brief timeout.

Please see our FAQ for further information.

📥 Commits

Reviewing files that changed from the base of the PR and between c6c5b4f and 6f1426b.

📒 Files selected for processing (1)

• src/app/fyle/view-expense/view-expense.page.scss (2 hunks)

Walkthrough

The changes in this pull request focus on the view-expense component, specifically modifying the HTML and SCSS files. The HTML structure for displaying expense details has been reorganized for clarity, with updates to the conditional rendering of project and card transaction information. The SCSS file reflects adjustments in styling, including font sizes and alignment properties, enhancing the overall layout. A new currency formatting pipe, exactCurrency, has been introduced to improve the presentation of financial data.

Changes

File Path	Change Summary
src/app/fyle/view-expense/view-expense.page.html	Reorganized HTML structure for expense details; updated conditional rendering for project and card transaction info; replaced humanizeCurrency with exactCurrency pipe for amount display.
src/app/fyle/view-expense/view-expense.page.scss	Adjusted styling properties including alignment, font sizes, and spacing for various elements within the .view-expense class; removed unnecessary classes.

Possibly related PRs

• feat: Update create-new-report amount section #3315: Updates the create-new-report component to use the exactCurrency pipe for displaying amounts.
• feat: Add to expenses to report section (Use Exact Amount) #3322: Modifies the add-txn-to-report-dialog component to use the exactCurrency pipe for displaying report amounts.
• feat: Update view report (reports--card) to display the exact amount #3330: Enhances the report view to display amounts using the exactCurrency pipe.
• feat: Add expenses to report (display exact amount) #3331: Updates the add-expenses-to-report component to display the total amount using the exactCurrency pipe.

Suggested labels

size/M

Suggested reviewers

• Dimple16

🎉 In the realm of expenses, changes take flight,
With exactCurrency, amounts shine bright!
From styling to structure, all is in place,
Clarity and beauty, we now embrace.
Rajinikanth style, with flair we display,
A new dawn for expenses, hip-hip-hooray! 🎉

---

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

• Review comments: Directly reply to a review comment made by CodeRabbit. Example:
  • I pushed a fix in commit <commit_id>, please review it.
  • Generate unit testing code for this file.
  • Open a follow-up GitHub issue for this discussion.
• Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
  • @coderabbitai generate unit testing code for this file.
  • @coderabbitai modularize this function.
• PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
  • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
  • @coderabbitai read src/utils.ts and generate unit testing code.
  • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
  • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

• @coderabbitai pause to pause the reviews on a PR.
• @coderabbitai resume to resume the paused reviews.
• @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
• @coderabbitai full review to do a full review from scratch and review all the files again.
• @coderabbitai summary to regenerate the summary of the PR.
• @coderabbitai generate docstrings to generate docstrings for this PR. (Experiment)
• @coderabbitai resolve resolve all the CodeRabbit review comments.
• @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
• @coderabbitai help to get help.

Other keywords and placeholders

• Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
• Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
• Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

• You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
• Please see the configuration documentation for more information.
• If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

• Visit our Documentation for detailed information on how to use CodeRabbit.
• Join our Discord Community to get help, request features, and share feedback.
• Follow us on X/Twitter for updates and announcements.

[coderabbitai]

Actionable comments posted: 1

📜 Review details

Configuration used: CodeRabbit UI
Review profile: ASSERTIVE
Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between aa39031 and c6c5b4f.

📒 Files selected for processing (2)

• src/app/fyle/view-expense/view-expense.page.html (2 hunks)
• src/app/fyle/view-expense/view-expense.page.scss (2 hunks)

🔇 Additional comments (5)

src/app/fyle/view-expense/view-expense.page.scss (3)

61-63: Mind-blowing alignment changes, partner!

The switch from flex-end to flex-start and the use of padding instead of margin creates a more balanced layout. Like a perfectly choreographed dance sequence!

---

69-69: Style makeover that packs a punch!

The new font sizes create a better visual hierarchy. The category at 14px and merchant at 12px with dark-grey color - it's like a perfectly balanced action sequence!

Also applies to: 74-75

---

95-97: Amount styling that makes an entrance!

The 16px font size for the amount, combined with that bold black color - now that's what I call a stylish presentation!

src/app/fyle/view-expense/view-expense.page.html (2)

62-62: Like a boss, you've nailed the currency display!

Using exactCurrency pipe with skipSymbol: true - that's the precision we needed!

---

83-89: Project and card info presentation - what a blockbuster move!

The way you've organized the project details and masked that card number - that's some next-level security style!

[coderabbitai]

🧹 Nitpick (assertive)

Time to settle the score with that TODO, partner!

That TODO about renaming etxn to expense in the navigation footer - shall we take care of it now?

Would you like me to help create a GitHub issue to track this terminology update task?

[github-actions]

Unit Test Coverage	%	values
Statements	96.03%	( 19280 / 20075 )
Branches	91.14%	( 10656 / 11691 )
Functions	94.38%	( 5737 / 6078 )
Lines	96.08%	( 18410 / 19161 )