FvwmPager: Fix SolidSeparators option #1139
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The dashed line GC is set before user options are parsed, so only newly created DeskStyles will have the dashed_gc set to a solid line. This means that when showing multiple desks, no desks will have a solid line, or when showing the current desk, the initial desk will not have a solid line, but other desks will. The label_gc uses the same fg color as dashed_gc, and can be used to create solid lines. So instead of relying on dashed_gc to know if solid lines should be used or not, use either label_gc or dashed_gc to draw the separators depending on if the option SolidSeparators is used or not. Fixes #1138
ThomasAdam
added
type:bug
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The dashed line GC is set before user options are parsed, so only newly created DeskStyles will have the dashed_gc set to a solid line. This means that when showing multiple desks, no desks will have a solid line, or when showing the current desk, the initial desk will not have a solid line, but other desks will.
The label_gc uses the same fg color as dashed_gc, and can be used to create solid lines. So instead of relying on dashed_gc to know if solid lines should be used or not, use either label_gc or dashed_gc to draw the separators depending on if the option SolidSeparators is used or not.
Fixes #1138