FvwmPager: The SolidSeparators option doesn't affect the first desk shown or multiple desks #1138
Labels
type:bug
Something's broken!
Comments
somiaj
changed the title
|
In my initial testing seems to be worse than that. If you are showing multiple desks at the same time, |
somiaj
added a commit
that referenced
this issue
Dec 10, 2024
The dashed line GC is set before user options are parsed, so only newly created DeskStyles will have the dashed_gc set to a solid line. This means that when showing multiple desks, no desks will have a solid line, or when showing the current desk, the initial desk will not have a solid line, but other desks will. The label_gc uses the same fg color as dashed_gc, and can be used to create solid lines. So instead of relying on dashed_gc to know if solid lines should be used or not, use either label_gc or dashed_gc to draw the separators depending on if the option SolidSeparators is used or not. Fixes #1138
|
@vanillechose I believe #1139 should fix the issue (does in my testing). If you can let us know if it works for you, that would be great. |
ThomasAdam
pushed a commit
that referenced
this issue
Dec 10, 2024
The dashed line GC is set before user options are parsed, so only newly created DeskStyles will have the dashed_gc set to a solid line. This means that when showing multiple desks, no desks will have a solid line, or when showing the current desk, the initial desk will not have a solid line, but other desks will. The label_gc uses the same fg color as dashed_gc, and can be used to create solid lines. So instead of relying on dashed_gc to know if solid lines should be used or not, use either label_gc or dashed_gc to draw the separators depending on if the option SolidSeparators is used or not. Fixes #1138
It works for me :) thank you very much. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Upfront Information
Fvwm3 version (run:
fvwm3 --version):fvwm3 1.1.2 (1.1.1-3-g27fd3cae)(latest commit of the main branch)Linux distribution or BSD name/version: Void Linux
Platform (run:
uname -sp): Linux unknownExpected Behaviour
The SolidSeparators configuration option of FvwmPager should work regardless of which desktop the pager is showing.
Actual Behaviour
When SolidPager is set, the first desk displayed by FvwmPager (after start or a restart of fvwm) is drawn with dashed instead of solid lines. When switching between desks, all the other desks are drawn with solid separators.
Enabling logging
The log file doesn't show anything related to the pager
Steps to Reproduce
I noticed this bug after updating to 1.1.0, and I was able to reproduce it using the latest commit of the main branch with the following configuration file
Extra Information
I took a video of the bug in case my description wasn't clear enough https://github.com/user-attachments/assets/0ead5482-7a31-40a4-9b9c-380264351410
The NoSeparators option still works properly.
The text was updated successfully, but these errors were encountered: