Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Froala 3 fixes #59

Closed
wants to merge 17 commits into from
Closed

Froala 3 fixes #59

Changes from 1 commit
Commits
Show all changes
17 commits
Select commit Hold shift + click to select a range
06116dc
Roll back to gulp 3.9.1 since tasks are v3 format
Jul 4, 2019
bf5f801
Fix set/observation of value
Jul 4, 2019
2c7adf0
Fix Indentiation
Jul 9, 2019
a9e74e6
Fix typo in comment
Jul 9, 2019
d8ff625
Make instance bindable.
Jul 9, 2019
e93e361
Fix Event Handlers
Jul 9, 2019
8a95bce
Set html after initialization
Jul 9, 2019
9946a60
Setup editor on correct element
Jul 9, 2019
d5446b2
Simplified checking if editor is initalized
Jul 10, 2019
dda4707
Refactor (spaces to tabs)
Jul 10, 2019
7b49c3c
(Refactor) Put code directly in attached/detached
Jul 10, 2019
96cc292
Rename instance to editor to better match the docs
Jul 10, 2019
daf234d
Add support for 'initialized' event handler
Jul 10, 2019
b6cc87e
Update to 3.0.3
Jul 16, 2019
d9f579f
Remove need for id selector
Jul 17, 2019
5c5c040
npm: Update to Froala Editor 3.0.6
Nov 19, 2019
288b950
Merge branch 'master' into Froala-3-Fixes
alexisszabo Nov 19, 2019
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -36,7 +36,7 @@
"babel-preset-stage-1": "^6.22.0",
"conventional-changelog": "^2.0.3",
"del": "^3.0.0",
"gulp": "^4.0.0",
"gulp": "^3.9.1",
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

but we can run those tasks with version 4. isn't it?

Copy link
Author

@alexisszabo alexisszabo Nov 19, 2019 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @kapil2704 , the gulp tasks were written with the 3.x syntax which fails with gulp 4. Since I was trying to minimize the changes, I rolled back the gulp version to 3.x instead of rewriting tasks in the 4.x syntax. Please see a related issue here: #60 (comment)

"gulp-babel": "^6.1.2",
"gulp-bump": "^2.7.0",
"gulp-eslint": "^3.0.1",
Expand Down