Froala 3 fixes #59
Froala 3 fixes #59
Conversation
Since component binding happend before attaching, we should not start listening for changes in value until the component has been attached.
Comments were using spaces, code was using tabs. Standardized on tabs
This is useful if we need access the instance after initialization
'data-froala.editor' no longer seems to be used in Froala 3
|
I updated the pull request to match the changes in 3.0.3-2 |
|
Hi @alexisszabo , Could you please Update your PR for this to be merged soon ? also please write purposes in more detail. Thanks, |
| @@ -36,7 +36,7 @@ | |||
| "babel-preset-stage-1": "^6.22.0", | |||
| "conventional-changelog": "^2.0.3", | |||
| "del": "^3.0.0", | |||
| "gulp": "^4.0.0", | |||
| "gulp": "^3.9.1", | |||
There was a problem hiding this comment.
but we can run those tasks with version 4. isn't it?
There was a problem hiding this comment.
Hi @kapil2704 , the gulp tasks were written with the 3.x syntax which fails with gulp 4. Since I was trying to minimize the changes, I rolled back the gulp version to 3.x instead of rewriting tasks in the 4.x syntax. Please see a related issue here: #60 (comment)
| @@ -101,7 +101,7 @@ define(['exports', 'aurelia-framework', 'aurelia-binding', './froala-editor-conf | |||
| } | |||
| })]; | |||
|
|
|||
| this.editor = new _froala_editorPkgdMin2.default('#' + this.element.id + ' ' + editorSelector, Object.assign({}, this.config), function () { | |||
| this.editor = new _froala_editorPkgdMin2.default(this.element.querySelector(editorSelector), Object.assign({}, this.config), function () { | |||
There was a problem hiding this comment.
it will select first element of that type. not that particular element?
There was a problem hiding this comment.
That's correct. However, for example, since we are searching only within the element itself, and there is only one 'textarea', we will get that.
This is similar to the old code:
if (this.config.iframe) {
this.instance = this.element.getElementsByTagName('textarea')[0];
}
else {
this.instance = this.element.getElementsByTagName('div')[0];
}
@kapil2704 I updated the PR to use version 3.0.6 of the froala-editor. Also resolved merge conflicts. Is more detail needed than what is in #59 (comment) ? |
|
HI @kapil2704 , Can we get an update the on the status of v3 support? Thanks, |
|
Closed PR. Old and better to fix the latest official version. |
Thanks for putting together this component. Made it nice and easy to integrate the froala-editor in v2.9.5. After upgrading to v3, I noticed that a number of things were no longer working. Since I needed this urgently for a project I am working on, I made some updates to aurelia-froala-editor to work nicely with v3. If you approve, can this be merged into the mainstream? Please let me know if any questions or edits needed.
This pull request:
Please note, I did not test with the iframe setting set to true.