Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Copying logs file #113

Merged
merged 2 commits into from
Apr 9, 2024
Merged

Copying logs file #113

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
c3161a4
Copy logs file
tharapalanivel Apr 9, 2024
11fa06d
Remove unnecessary import
tharapalanivel Apr 9, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 5 additions & 4 deletions build/launch_training.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -21,7 +21,6 @@
import os
import tempfile
import shutil
import glob

# First Party
import logging
Expand Down Expand Up @@ -107,9 +106,11 @@ def main():
dirs_exist_ok=True,
)

# copy over any loss logs
for file in glob.glob(f"{training_args.output_dir}/*loss.jsonl"):
shutil.copy(file, original_output_dir)
# copy over logs
shutil.copy(
os.path.join(training_args.output_dir, sft_trainer.TRAINING_LOGS_FILENAME),
original_output_dir,
)


if __name__ == "__main__":
Expand Down
4 changes: 3 additions & 1 deletion tuning/sft_trainer.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -48,6 +48,8 @@
# Local
from tuning.aim_loader import get_aimstack_callback

TRAINING_LOGS_FILENAME = "training_logs.jsonl"


class FileLoggingCallback(TrainerCallback):
"""Exports metrics, e.g., training loss to a file in the checkpoint directory."""
Expand All @@ -64,7 +66,7 @@ def on_log(self, args, state, control, logs=None, **kwargs):
if not state.is_world_process_zero:
return

log_file_path = os.path.join(args.output_dir, "training_logs.jsonl")
log_file_path = os.path.join(args.output_dir, TRAINING_LOGS_FILENAME)
if logs is not None and "loss" in logs and "epoch" in logs:
self._track_loss("loss", "training_loss", log_file_path, logs, state)
elif logs is not None and "eval_loss" in logs and "epoch" in logs:
Expand Down
Loading